mirror of
https://github.com/tiennm99/java-design-patterns.git
synced 2026-05-14 18:58:44 +00:00
refactor: remove code smell java:S5786 (#2159)
https://sonarcloud.io/organizations/iluwatar/rules?open=java%3AS5786&rule_key=java%3AS5786
This commit is contained in:
+2
-2
@@ -35,7 +35,7 @@ class ParameterObjectTest {
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(ParameterObjectTest.class);
|
||||
|
||||
@Test
|
||||
public void testForDefaultSortBy() {
|
||||
void testForDefaultSortBy() {
|
||||
//Creating parameter object with default value for SortBy set
|
||||
ParameterObject params = ParameterObject.newBuilder()
|
||||
.withType("sneakers")
|
||||
@@ -49,7 +49,7 @@ class ParameterObjectTest {
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testForDefaultSortOrder() {
|
||||
void testForDefaultSortOrder() {
|
||||
//Creating parameter object with default value for SortOrder set
|
||||
ParameterObject params = ParameterObject.newBuilder()
|
||||
.withType("sneakers")
|
||||
|
||||
@@ -37,7 +37,7 @@ class SearchServiceTest {
|
||||
private SearchService searchService;
|
||||
|
||||
@BeforeEach
|
||||
public void setUp() {
|
||||
void setUp() {
|
||||
//Creating parameter object with default values set
|
||||
parameterObject = ParameterObject.newBuilder()
|
||||
.withType("sneakers")
|
||||
@@ -50,7 +50,7 @@ class SearchServiceTest {
|
||||
* Testing parameter object against the overloaded method to verify if the behaviour is same.
|
||||
*/
|
||||
@Test
|
||||
public void testDefaultParametersMatch() {
|
||||
void testDefaultParametersMatch() {
|
||||
assertEquals(searchService.search(parameterObject), searchService.search("sneakers",
|
||||
SortOrder.ASC), "Default Parameter values do not not match.");
|
||||
LOGGER.info("SortBy Default parameter value matches.");
|
||||
|
||||
Reference in New Issue
Block a user