diff --git a/visitor/README.md b/visitor/README.md index 38df87d28..dae82966b 100644 --- a/visitor/README.md +++ b/visitor/README.md @@ -72,7 +72,7 @@ public class Commander extends Unit { @Override public void accept(UnitVisitor visitor) { - visitor.visitCommander(this); + visitor.visit(this); super.accept(visitor); } @@ -90,7 +90,7 @@ public class Sergeant extends Unit { @Override public void accept(UnitVisitor visitor) { - visitor.visitSergeant(this); + visitor.visit(this); super.accept(visitor); } @@ -108,7 +108,7 @@ public class Soldier extends Unit { @Override public void accept(UnitVisitor visitor) { - visitor.visitSoldier(this); + visitor.visit(this); super.accept(visitor); } @@ -126,17 +126,17 @@ Here are then some concrete visitors. public class CommanderVisitor implements UnitVisitor { @Override - public void visitSoldier(Soldier soldier) { + public void visit(Soldier soldier) { // Do nothing } @Override - public void visitSergeant(Sergeant sergeant) { + public void visit(Sergeant sergeant) { // Do nothing } @Override - public void visitCommander(Commander commander) { + public void visit(Commander commander) { LOGGER.info("Good to see you {}", commander); } } @@ -145,17 +145,17 @@ public class CommanderVisitor implements UnitVisitor { public class SergeantVisitor implements UnitVisitor { @Override - public void visitSoldier(Soldier soldier) { + public void visit(Soldier soldier) { // Do nothing } @Override - public void visitSergeant(Sergeant sergeant) { + public void visit(Sergeant sergeant) { LOGGER.info("Hello {}", sergeant); } @Override - public void visitCommander(Commander commander) { + public void visit(Commander commander) { // Do nothing } } @@ -164,17 +164,17 @@ public class SergeantVisitor implements UnitVisitor { public class SoldierVisitor implements UnitVisitor { @Override - public void visitSoldier(Soldier soldier) { + public void visit(Soldier soldier) { LOGGER.info("Greetings {}", soldier); } @Override - public void visitSergeant(Sergeant sergeant) { + public void visit(Sergeant sergeant) { // Do nothing } @Override - public void visitCommander(Commander commander) { + public void visit(Commander commander) { // Do nothing } } diff --git a/visitor/src/main/java/com/iluwatar/visitor/Commander.java b/visitor/src/main/java/com/iluwatar/visitor/Commander.java index a6c7aebcb..01c8a43ba 100644 --- a/visitor/src/main/java/com/iluwatar/visitor/Commander.java +++ b/visitor/src/main/java/com/iluwatar/visitor/Commander.java @@ -33,9 +33,13 @@ public class Commander extends Unit { super(children); } + /** + * Accept a Visitor. + * @param visitor UnitVisitor to be accepted + */ @Override public void accept(UnitVisitor visitor) { - visitor.visitCommander(this); + visitor.visit(this); super.accept(visitor); } diff --git a/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java index 59bdc3597..a0286163a 100644 --- a/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java +++ b/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java @@ -32,18 +32,30 @@ import lombok.extern.slf4j.Slf4j; @Slf4j public class CommanderVisitor implements UnitVisitor { + /** + * Soldier Visitor method. + * @param soldier Soldier to be visited + */ @Override - public void visitSoldier(Soldier soldier) { + public void visit(Soldier soldier) { // Do nothing } + /** + * Sergeant Visitor method. + * @param sergeant Sergeant to be visited + */ @Override - public void visitSergeant(Sergeant sergeant) { + public void visit(Sergeant sergeant) { // Do nothing } + /** + * Commander Visitor method. + * @param commander Commander to be visited + */ @Override - public void visitCommander(Commander commander) { + public void visit(Commander commander) { LOGGER.info("Good to see you {}", commander); } } diff --git a/visitor/src/main/java/com/iluwatar/visitor/Sergeant.java b/visitor/src/main/java/com/iluwatar/visitor/Sergeant.java index 967832f4f..ed9fc98b5 100644 --- a/visitor/src/main/java/com/iluwatar/visitor/Sergeant.java +++ b/visitor/src/main/java/com/iluwatar/visitor/Sergeant.java @@ -33,9 +33,13 @@ public class Sergeant extends Unit { super(children); } + /** + * Accept a Visitor. + * @param visitor UnitVisitor to be accepted + */ @Override public void accept(UnitVisitor visitor) { - visitor.visitSergeant(this); + visitor.visit(this); super.accept(visitor); } diff --git a/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java index 5f394c9ed..3377806b9 100644 --- a/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java +++ b/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java @@ -32,18 +32,30 @@ import lombok.extern.slf4j.Slf4j; @Slf4j public class SergeantVisitor implements UnitVisitor { + /** + * Soldier Visitor method. + * @param soldier Soldier to be visited + */ @Override - public void visitSoldier(Soldier soldier) { + public void visit(Soldier soldier) { // Do nothing } + /** + * Sergeant Visitor method. + * @param sergeant Sergeant to be visited + */ @Override - public void visitSergeant(Sergeant sergeant) { + public void visit(Sergeant sergeant) { LOGGER.info("Hello {}", sergeant); } + /** + * Commander Visitor method. + * @param commander Commander to be visited + */ @Override - public void visitCommander(Commander commander) { + public void visit(Commander commander) { // Do nothing } } diff --git a/visitor/src/main/java/com/iluwatar/visitor/Soldier.java b/visitor/src/main/java/com/iluwatar/visitor/Soldier.java index e5aed76e2..30398374e 100644 --- a/visitor/src/main/java/com/iluwatar/visitor/Soldier.java +++ b/visitor/src/main/java/com/iluwatar/visitor/Soldier.java @@ -33,9 +33,13 @@ public class Soldier extends Unit { super(children); } + /** + * Accept a Visitor. + * @param visitor UnitVisitor to be accepted + */ @Override public void accept(UnitVisitor visitor) { - visitor.visitSoldier(this); + visitor.visit(this); super.accept(visitor); } diff --git a/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java index 7f432bfa6..6827c82d5 100644 --- a/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java +++ b/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java @@ -32,18 +32,30 @@ import lombok.extern.slf4j.Slf4j; @Slf4j public class SoldierVisitor implements UnitVisitor { + /** + * Soldier Visitor method. + * @param soldier Soldier to be visited + */ @Override - public void visitSoldier(Soldier soldier) { + public void visit(Soldier soldier) { LOGGER.info("Greetings {}", soldier); } + /** + * Sergeant Visitor method. + * @param sergeant Sergeant to be visited + */ @Override - public void visitSergeant(Sergeant sergeant) { + public void visit(Sergeant sergeant) { // Do nothing } + /** + * Commander Visitor method. + * @param commander Commander to be visited + */ @Override - public void visitCommander(Commander commander) { + public void visit(Commander commander) { // Do nothing } } diff --git a/visitor/src/main/java/com/iluwatar/visitor/UnitVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/UnitVisitor.java index 4e68fe1f9..af6090228 100644 --- a/visitor/src/main/java/com/iluwatar/visitor/UnitVisitor.java +++ b/visitor/src/main/java/com/iluwatar/visitor/UnitVisitor.java @@ -29,10 +29,10 @@ package com.iluwatar.visitor; */ public interface UnitVisitor { - void visitSoldier(Soldier soldier); + void visit(Soldier soldier); - void visitSergeant(Sergeant sergeant); + void visit(Sergeant sergeant); - void visitCommander(Commander commander); + void visit(Commander commander); } diff --git a/visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java b/visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java index 273e8847f..27df66894 100644 --- a/visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java +++ b/visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java @@ -43,7 +43,7 @@ public class CommanderTest extends UnitTest { @Override void verifyVisit(Commander unit, UnitVisitor mockedVisitor) { - verify(mockedVisitor).visitCommander(eq(unit)); + verify(mockedVisitor).visit(eq(unit)); } } \ No newline at end of file diff --git a/visitor/src/test/java/com/iluwatar/visitor/SergeantTest.java b/visitor/src/test/java/com/iluwatar/visitor/SergeantTest.java index bfc25d8a3..968c6afcb 100644 --- a/visitor/src/test/java/com/iluwatar/visitor/SergeantTest.java +++ b/visitor/src/test/java/com/iluwatar/visitor/SergeantTest.java @@ -43,7 +43,7 @@ public class SergeantTest extends UnitTest { @Override void verifyVisit(Sergeant unit, UnitVisitor mockedVisitor) { - verify(mockedVisitor).visitSergeant(eq(unit)); + verify(mockedVisitor).visit(eq(unit)); } } \ No newline at end of file diff --git a/visitor/src/test/java/com/iluwatar/visitor/SoldierTest.java b/visitor/src/test/java/com/iluwatar/visitor/SoldierTest.java index 45e8340ad..f449911e4 100644 --- a/visitor/src/test/java/com/iluwatar/visitor/SoldierTest.java +++ b/visitor/src/test/java/com/iluwatar/visitor/SoldierTest.java @@ -43,7 +43,7 @@ public class SoldierTest extends UnitTest { @Override void verifyVisit(Soldier unit, UnitVisitor mockedVisitor) { - verify(mockedVisitor).visitSoldier(eq(unit)); + verify(mockedVisitor).visit(eq(unit)); } } \ No newline at end of file diff --git a/visitor/src/test/java/com/iluwatar/visitor/VisitorTest.java b/visitor/src/test/java/com/iluwatar/visitor/VisitorTest.java index 64368e56d..ff4c43602 100644 --- a/visitor/src/test/java/com/iluwatar/visitor/VisitorTest.java +++ b/visitor/src/test/java/com/iluwatar/visitor/VisitorTest.java @@ -98,7 +98,7 @@ public abstract class VisitorTest { @Test void testVisitCommander() { - this.visitor.visitCommander(new Commander()); + this.visitor.visit(new Commander()); if (this.commanderResponse.isPresent()) { assertEquals(this.commanderResponse.get(), appender.getLastMessage()); assertEquals(1, appender.getLogSize()); @@ -107,7 +107,7 @@ public abstract class VisitorTest { @Test void testVisitSergeant() { - this.visitor.visitSergeant(new Sergeant()); + this.visitor.visit(new Sergeant()); if (this.sergeantResponse.isPresent()) { assertEquals(this.sergeantResponse.get(), appender.getLastMessage()); assertEquals(1, appender.getLogSize()); @@ -116,7 +116,7 @@ public abstract class VisitorTest { @Test void testVisitSoldier() { - this.visitor.visitSoldier(new Soldier()); + this.visitor.visit(new Soldier()); if (this.soldierResponse.isPresent()) { assertEquals(this.soldierResponse.get(), appender.getLastMessage()); assertEquals(1, appender.getLogSize());