508 : sonar qube critical issue fixes (#852)

mirror of https://github.com/tiennm99/java-design-patterns.git synced 2026-05-16 02:59:21 +00:00

* 508 : sonar qube critical issue fixes

* 508 : Sunar Qube Fixes
Define a constant instead of duplicating this literal "user_accounts" 4 times.
Define a constant instead of duplicating this literal "userID" 5 times
Define a constant instead of duplicating this literal "additionalInfo" 4 times.
Define a constant instead of duplicating this literal "userName" 4 times.

* 508 : Sunar Qube Fixes
Define a constant instead of duplicating this literal "user_accounts" 4 times.

* 508 : Sonar Qube Fixes
Define a constant instead of duplicating this literal "eEvans" 4 times
Define a constant instead of duplicating this literal "jBloch" 6 times
Define a constant instead of duplicating this literal "mFowler" 3 times

* 508 : Sonar Qube FIxes
Define a constant instead of duplicating this literal "username" 3 times.

* 508: sonar qube issue fixes
Define a constant instead of duplicating this literal "customerDao.getAllCustomers(): " 4 times.

* 508 : sonar qube issue fixes
Define a constant instead of duplicating this literal "App.main(), student : " 4 times.

* 508 : sonar Qube issue fixes
Define a constant instead of duplicating this literal "{} hits {}. {} is damaged!" 3 times.
Define a constant instead of duplicating this literal "{} hits {}." 4 times.

* 508 : Define a constant instead of duplicating this literal "{} hits {}." 4 times.

* 508 : checkstyle fixes

* 508: checkstyle fixes

* 508: cqrs checkstyle fixes

This commit is contained in:

kanwarpreet25

2019-07-28 18:09:40 +05:30

committed by

Ilkka Seppälä

parent 17bfc91f45

commit c6ecf58687

17 changed files with 146 additions and 87 deletions

									
										abstract-document/src/main/java/com/iluwatar/abstractdocument/domain/HasPrice.java
									
		+2
		-2
	
												View File
												
				@@ -25,16 +25,16 @@ package com.iluwatar.abstractdocument.domain;

				import java.util.Optional;

				import com.iluwatar.abstractdocument.Document;

				import com.iluwatar.abstractdocument.domain.enums.Property;

				/**

				 * HasPrice trait for static access to 'price' property

				 */

				public interface HasPrice extends Document {

				  String PROPERTY = "price";

				  default Optional<Number> getPrice() {

				    return Optional.ofNullable((Number) get(PROPERTY));

				    return Optional.ofNullable((Number) get(Property.PRICE.toString()));

				  }

				}