dependencies: #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve chec… (#2464)

* #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve checkstyle issues

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* add refactored file with correct filename to resolve checkstyle issue

* add the test data

* change filenames from JFrame to Jframe for checkstyle

* fix code smell from  sonar report

* add new testcases to improve the test coverage

* remove code smell

domain-model/src/main/java/com/iluwatar/domainmodel/App.java

@@ -29,7 +29,6 @@ import static org.joda.money.CurrencyUnit.USD;
 import java.sql.SQLException;
 import java.time.LocalDate;
 import javax.sql.DataSource;
-
 import org.h2.jdbcx.JdbcDataSource;
 import org.joda.money.Money;
 

domain-model/src/main/java/com/iluwatar/domainmodel/Customer.java

@@ -28,7 +28,6 @@ import java.sql.SQLException;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
-
 import lombok.Builder;
 import lombok.Getter;
 import lombok.NonNull;

domain-model/src/main/java/com/iluwatar/domainmodel/CustomerDao.java

@@ -27,6 +27,9 @@ package com.iluwatar.domainmodel;
 import java.sql.SQLException;
 import java.util.Optional;
 
+/**
+ * DAO interface for customer transactions.
+ */
 public interface CustomerDao {
 
   Optional<Customer> findByName(String name) throws SQLException;

domain-model/src/main/java/com/iluwatar/domainmodel/CustomerDaoImpl.java

@@ -30,9 +30,11 @@ import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.Optional;
 import javax.sql.DataSource;
-
 import org.joda.money.Money;
 
+/**
+ * Implementations for database operations of Customer.
+ */
 public class CustomerDaoImpl implements CustomerDao {
 
   private final DataSource dataSource;

domain-model/src/main/java/com/iluwatar/domainmodel/Product.java

@@ -31,7 +31,6 @@ import java.sql.SQLException;
 import java.time.LocalDate;
 import java.time.temporal.ChronoUnit;
 import java.util.Optional;
-
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Getter;

domain-model/src/main/java/com/iluwatar/domainmodel/ProductDao.java

@@ -27,6 +27,9 @@ package com.iluwatar.domainmodel;
 import java.sql.SQLException;
 import java.util.Optional;
 
+/**
+ * DAO interface for product transactions.
+ */
 public interface ProductDao {
 
   Optional<Product> findByName(String name) throws SQLException;

domain-model/src/main/java/com/iluwatar/domainmodel/ProductDaoImpl.java

@@ -31,10 +31,11 @@ import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.Optional;
 import javax.sql.DataSource;
-
 import org.joda.money.Money;
 
-
+/**
+ * Implementations for database transactions of Product.
+ */
 public class ProductDaoImpl implements ProductDao {
 
   private final DataSource dataSource;