tiennm99/java-design-patterns
1
0
Fork 0
mirror of https://github.com/tiennm99/java-design-patterns.git synced 2026-05-14 16:58:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

dependencies: #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve chec… (#2464)

Browse Source 
* #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve checkstyle issues

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* add refactored file with correct filename to resolve checkstyle issue

* add the test data

* change filenames from JFrame to Jframe for checkstyle

* fix code smell from  sonar report

* add new testcases to improve the test coverage

* remove code smell
This commit is contained in:
Rahul Raj
2023-02-04 22:50:54 +05:30
committed by GitHub
parent dbecffacab
commit fb7ec9b375
147 changed files with 487 additions and 289 deletions
Download Patch File Download Diff File Expand all files Collapse all files
embedded-value/src/main/java/com/iluwatar/embedded/value/DataSource.java
+14 -22
View File
@@ -31,36 +31,29 @@ import java.sql.SQLException;
import java.sql.Statement;
import java.util.ArrayList;
import java.util.stream.Stream;
import lombok.extern.slf4j.Slf4j;
/*
* Communicates with H2 database with the help of JDBC API
*
* Inherits the SQL queries and methods from @link AbstractDataSource class
*/
/**
* Communicates with H2 database with the help of JDBC API.
* Inherits the SQL queries and methods from @link AbstractDataSource class.
*/
@Slf4j
public class DataSource implements DataSourceInterface {
private Connection conn;
/**
* Statements are objects which are used to execute queries which will not be
* repeated.
*/
// Statements are objects which are used to execute queries which will not be repeated.
private Statement getschema;
private Statement deleteschema;
private Statement queryOrders;
/*
* PreparedStatements are used to execute queries which will be repeated.
*/
// PreparedStatements are used to execute queries which will be repeated.
private PreparedStatement insertIntoOrders;
private PreparedStatement removeorder;
private PreparedStatement queyOrderByID;
private PreparedStatement queyOrderById;
/**
* {@summary}
* Establish connection to database.
* {@summary Establish connection to database.
* Constructor to create DataSource object.}
*/
public DataSource() {
try {
@@ -79,7 +72,7 @@ public class DataSource implements DataSourceInterface {
getschema = conn.createStatement();
queryOrders = conn.createStatement();
removeorder = conn.prepareStatement(REMOVE_ORDER);
queyOrderByID = conn.prepareStatement(QUERY_ORDER);
queyOrderById = conn.prepareStatement(QUERY_ORDER);
deleteschema = conn.createStatement();
} catch (SQLException e) {
LOGGER.error(e.getLocalizedMessage(), e.getCause());
@@ -156,7 +149,6 @@ public class DataSource implements DataSourceInterface {
}
/**
* {@summary}
* Query order by given id.
* @param id as the parameter
* @return Order objct
@@ -166,9 +158,9 @@ public class DataSource implements DataSourceInterface {
@Override
public Order queryOrder(int id) throws SQLException {
Order order = null;
queyOrderByID.setInt(1, id);
try (var rSet = queyOrderByID.executeQuery()) {
queyOrderByID.setInt(1, id);
queyOrderById.setInt(1, id);
try (var rSet = queyOrderById.executeQuery()) {
queyOrderById.setInt(1, id);
if (rSet.next()) {
var address = new ShippingAddress(rSet.getString(4),
rSet.getString(5), rSet.getString(6));
@@ -204,7 +196,7 @@ public class DataSource implements DataSourceInterface {
try {
deleteschema.execute(DELETE_SCHEMA);
queryOrders.close();
queyOrderByID.close();
queyOrderById.close();
deleteschema.close();
insertIntoOrders.close();
conn.close();