dependencies: #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve chec… (#2464)

* #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve checkstyle issues

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* add refactored file with correct filename to resolve checkstyle issue

* add the test data

* change filenames from JFrame to Jframe for checkstyle

* fix code smell from  sonar report

* add new testcases to improve the test coverage

* remove code smell

identity-map/src/main/java/com/iluwatar/identitymap/IdNotFoundException.java

@@ -24,6 +24,9 @@
  */
 package com.iluwatar.identitymap;
 
+/**
+ * Using Runtime Exception to control the flow in case Person Id doesn not exist.
+ */
 public class IdNotFoundException extends RuntimeException {
   public IdNotFoundException(final String message) {
     super(message);

identity-map/src/main/java/com/iluwatar/identitymap/IdentityMap.java

@@ -26,7 +26,6 @@ package com.iluwatar.identitymap;
 
 import java.util.HashMap;
 import java.util.Map;
-
 import lombok.Getter;
 import lombok.extern.slf4j.Slf4j;
 

identity-map/src/main/java/com/iluwatar/identitymap/Person.java

@@ -25,7 +25,6 @@
 package com.iluwatar.identitymap;
 
 import java.io.Serializable;
-
 import lombok.AllArgsConstructor;
 import lombok.EqualsAndHashCode;
 import lombok.Getter;

identity-map/src/main/java/com/iluwatar/identitymap/PersonDbSimulator.java

@@ -24,13 +24,16 @@
  */
 package com.iluwatar.identitymap;
 
+/**
+ * Simulator interface for Person DB.
+ */
 public interface PersonDbSimulator {
-  Person find(int personNationalID);
+  Person find(int personNationalId);
 
   void insert(Person person);
 
   void update(Person person);
 
-  void delete(int personNationalID);
+  void delete(int personNationalId);
 
 }

identity-map/src/main/java/com/iluwatar/identitymap/PersonDbSimulatorImplementation.java

@@ -27,7 +27,6 @@ package com.iluwatar.identitymap;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
-
 import lombok.extern.slf4j.Slf4j;
 
 /**
@@ -49,10 +48,10 @@ public class PersonDbSimulatorImplementation implements PersonDbSimulator {
   static final String ID_STR = "ID : ";
 
   @Override
-  public Person find(int personNationalID) throws IdNotFoundException {
-    Optional<Person> elem = personList.stream().filter(p -> p.getPersonNationalId() == personNationalID).findFirst();
+  public Person find(int personNationalId) throws IdNotFoundException {
+    Optional<Person> elem = personList.stream().filter(p -> p.getPersonNationalId() == personNationalId).findFirst();
     if (elem.isEmpty()) {
-      throw new IdNotFoundException(ID_STR + personNationalID + NOT_IN_DATA_BASE);
+      throw new IdNotFoundException(ID_STR + personNationalId + NOT_IN_DATA_BASE);
     }
     LOGGER.info(elem.get().toString());
     return elem.get();