dependencies: #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve chec… (#2464)

* #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve checkstyle issues

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* add refactored file with correct filename to resolve checkstyle issue

* add the test data

* change filenames from JFrame to Jframe for checkstyle

* fix code smell from  sonar report

* add new testcases to improve the test coverage

* remove code smell

model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/App.java

@@ -31,7 +31,7 @@ package com.iluwatar.model.view.presenter;
  * (Presenter).
  *
  * <p>In the following example, The {@link FileLoader} class represents the app's logic, the {@link
- * FileSelectorJFrame} is the GUI and the {@link FileSelectorPresenter} is responsible to respond to
+ * FileSelectorJframe} is the GUI and the {@link FileSelectorPresenter} is responsible to respond to
  * users' actions.
  *
  * <p>Finally, please notice the wiring between the Presenter and the View and between the
@@ -46,7 +46,7 @@ public class App {
    */
   public static void main(String[] args) {
     var loader = new FileLoader();
-    var frame = new FileSelectorJFrame();
+    var frame = new FileSelectorJframe();
     var presenter = new FileSelectorPresenter(frame);
     presenter.setLoader(loader);
     presenter.start();

model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/FileSelectorJframe.java

@@ -30,7 +30,6 @@ import static javax.swing.ScrollPaneConstants.VERTICAL_SCROLLBAR_AS_NEEDED;
 import java.awt.Color;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
-
 import javax.swing.JButton;
 import javax.swing.JFrame;
 import javax.swing.JLabel;
@@ -43,7 +42,7 @@ import javax.swing.JTextField;
 /**
  * This class is the GUI implementation of the View component in the Model-View-Presenter pattern.
  */
-public class FileSelectorJFrame extends JFrame implements FileSelectorView, ActionListener {
+public class FileSelectorJframe extends JFrame implements FileSelectorView, ActionListener {
 
   /**
    * Default serial version ID.
@@ -83,7 +82,7 @@ public class FileSelectorJFrame extends JFrame implements FileSelectorView, Acti
   /**
    * Constructor.
    */
-  public FileSelectorJFrame() {
+  public FileSelectorJframe() {
     super("File Loader");
     this.setDefaultCloseOperation(EXIT_ON_CLOSE);
     this.setLayout(null);

model-view-presenter/src/test/java/com/iluwatar/model/view/presenter/FileSelectorJframeTest.java

@@ -0,0 +1,52 @@
+/*
+ * This project is licensed under the MIT license. Module model-view-presenter is using ZK framework licensed under LGPL (see lgpl-3.0.txt).
+ *
+ * The MIT License
+ * Copyright © 2014-2022 Ilkka Seppälä
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+package com.iluwatar.model.view.presenter;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
+import java.awt.event.ActionEvent;
+
+import org.junit.jupiter.api.Test;
+
+/**
+ * Date: 01/29/23 - 6:00 PM
+ *
+ * @author Rahul Raj
+ */
+class FileSelectorJframeTest {
+    
+    /**
+     * Tests if the jframe action event is triggered without any exception.
+     */
+    @Test
+    void testActionEvent() {
+      assertDoesNotThrow(() ->{
+        FileSelectorJframe jFrame = new FileSelectorJframe();
+        ActionEvent action = new ActionEvent("dummy", 1, "dummy");
+        jFrame.actionPerformed(action);
+      });
+    }
+
+}

model-view-presenter/src/test/java/com/iluwatar/model/view/presenter/FileSelectorPresenterTest.java

@@ -144,4 +144,16 @@ class FileSelectorPresenterTest {
 
     assertFalse(stub.isOpened());
   }
+
+  @Test
+  void testNullFile() {
+    stub.setFileName(null);
+    presenter.start();
+    presenter.fileNameChanged();
+    presenter.confirmed();
+
+    assertFalse(loader.isLoaded());
+    assertFalse(stub.dataDisplayed());
+  }
+
 }