mirror of
https://github.com/tiennm99/java-design-patterns.git
synced 2026-05-18 02:59:19 +00:00
* #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve checkstyle issues * remove FileSelectorJFrame.java to resolve checkstyle issue * remove FileSelectorJFrame.java to resolve checkstyle issue * remove FileSelectorJFrame.java to resolve checkstyle issue * add refactored file with correct filename to resolve checkstyle issue * add the test data * change filenames from JFrame to Jframe for checkstyle * fix code smell from sonar report * add new testcases to improve the test coverage * remove code smell
This commit is contained in:
@@ -31,7 +31,7 @@ package com.iluwatar.model.view.presenter;
|
||||
* (Presenter).
|
||||
*
|
||||
* <p>In the following example, The {@link FileLoader} class represents the app's logic, the {@link
|
||||
* FileSelectorJFrame} is the GUI and the {@link FileSelectorPresenter} is responsible to respond to
|
||||
* FileSelectorJframe} is the GUI and the {@link FileSelectorPresenter} is responsible to respond to
|
||||
* users' actions.
|
||||
*
|
||||
* <p>Finally, please notice the wiring between the Presenter and the View and between the
|
||||
@@ -46,7 +46,7 @@ public class App {
|
||||
*/
|
||||
public static void main(String[] args) {
|
||||
var loader = new FileLoader();
|
||||
var frame = new FileSelectorJFrame();
|
||||
var frame = new FileSelectorJframe();
|
||||
var presenter = new FileSelectorPresenter(frame);
|
||||
presenter.setLoader(loader);
|
||||
presenter.start();
|
||||
|
||||
+2
-3
@@ -30,7 +30,6 @@ import static javax.swing.ScrollPaneConstants.VERTICAL_SCROLLBAR_AS_NEEDED;
|
||||
import java.awt.Color;
|
||||
import java.awt.event.ActionEvent;
|
||||
import java.awt.event.ActionListener;
|
||||
|
||||
import javax.swing.JButton;
|
||||
import javax.swing.JFrame;
|
||||
import javax.swing.JLabel;
|
||||
@@ -43,7 +42,7 @@ import javax.swing.JTextField;
|
||||
/**
|
||||
* This class is the GUI implementation of the View component in the Model-View-Presenter pattern.
|
||||
*/
|
||||
public class FileSelectorJFrame extends JFrame implements FileSelectorView, ActionListener {
|
||||
public class FileSelectorJframe extends JFrame implements FileSelectorView, ActionListener {
|
||||
|
||||
/**
|
||||
* Default serial version ID.
|
||||
@@ -83,7 +82,7 @@ public class FileSelectorJFrame extends JFrame implements FileSelectorView, Acti
|
||||
/**
|
||||
* Constructor.
|
||||
*/
|
||||
public FileSelectorJFrame() {
|
||||
public FileSelectorJframe() {
|
||||
super("File Loader");
|
||||
this.setDefaultCloseOperation(EXIT_ON_CLOSE);
|
||||
this.setLayout(null);
|
||||
Reference in New Issue
Block a user