mirror of
https://github.com/tiennm99/java-design-patterns.git
synced 2026-05-14 10:58:42 +00:00
* #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve checkstyle issues * remove FileSelectorJFrame.java to resolve checkstyle issue * remove FileSelectorJFrame.java to resolve checkstyle issue * remove FileSelectorJFrame.java to resolve checkstyle issue * add refactored file with correct filename to resolve checkstyle issue * add the test data * change filenames from JFrame to Jframe for checkstyle * fix code smell from sonar report * add new testcases to improve the test coverage * remove code smell
This commit is contained in:
@@ -68,9 +68,9 @@ public class Bubble extends Point<Bubble> {
|
||||
var toBePopped = false; //if any other bubble collides with it, made true
|
||||
for (var point : toCheck) {
|
||||
var otherId = point.id;
|
||||
if (allBubbles.get(otherId) != null && //the bubble hasn't been popped yet
|
||||
this.id != otherId && //the two bubbles are not the same
|
||||
this.touches(allBubbles.get(otherId))) { //the bubbles touch
|
||||
if (allBubbles.get(otherId) != null //the bubble hasn't been popped yet
|
||||
&& this.id != otherId //the two bubbles are not the same
|
||||
&& this.touches(allBubbles.get(otherId))) { //the bubbles touch
|
||||
allBubbles.get(otherId).pop(allBubbles);
|
||||
toBePopped = true;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user