Commit Graph

82 Commits

Author SHA1 Message Date
mahendran.mookkiah e9579633da #587 SonarQube reports bugs in dao module 2017-09-15 17:39:01 -04:00
mahendran.mookkiah a1a4088087 As getAll method returns a Stream, we cannot close the involved
resources (Connection, Statement and resultSet) until the stream is
closed by the consumer. So try-with-resources is not an option as per
sonarqube’s recommendation. But it is still recommended to close
statement and result set. When connection pool used, connection is not
closed when close() called. It is just returned to the pool.

Using //NOSONAR to avoid false blocker issue.
2017-08-13 10:19:48 -04:00
Ilkka Seppälä ac721c695c Set version for next development iteration 2017-06-30 20:33:29 +03:00
Ilkka Seppälä d793160bce Reach milestone 1.16.0 2017-06-30 20:31:31 +03:00
Ilkka Seppälä 073d06c0ae Set version for next development iteration 2017-04-01 17:15:59 +03:00
Ilkka Seppälä 8fea969912 Reached milestone 1.15.0 2017-04-01 17:14:02 +03:00
Mudit Porwal 09585c3874 Removed AvoidStarImport Rule
Added JavaDocType Rule
2017-03-22 01:16:02 +08:00
Ilkka Seppälä a1ff55b462 #190 Regenerate puml files 2017-02-11 21:46:56 +02:00
Ilkka Seppälä 9ec0935a1c Merge pull request #532 from leogtzr/master
Adding initialization-on-demand idiom and noninstantiable class instead of interface constant idiom
2017-01-23 08:21:07 +02:00
Ilkka Seppälä 0c8bb1c22e Set version for next development iteration 2016-12-31 10:24:26 +02:00
Ilkka Seppälä 0c48695fa5 Achieved milestone 1.14.0 2016-12-31 10:23:32 +02:00
leogtzr 6292690250 Changing constant interface pattern with a Noninstantiable class 2016-12-24 14:49:41 -07:00
Ilkka Seppälä faa29f8025 Update license headers 2016-11-27 14:34:20 +02:00
NooBxGockeL 7d995056ff Update URM Version to 1.4.4 and regenerated all puml files 2016-11-26 12:51:06 +01:00
Ilkka Seppälä 4ca205c03c Set version number for next development iteration 2016-09-30 19:40:28 +03:00
Ilkka Seppälä c5e6dcc11b Reached milestone 1.13.0 2016-09-30 19:38:28 +03:00
Ilkka Seppälä 6026eedd51 UML generation: Mark the urm-maven-plugin execution to be ignored in Eclipse and recreate all .puml files 2016-09-18 17:51:09 +03:00
NooBxGockeL 58dce1bd89 Work on #190: Commit initial pumlId's added by the script 2016-08-30 15:10:34 +02:00
NooBxGockeL 36fe249960 Work on #190: Add first batch of automagically generated puml files 2016-08-30 13:29:12 +02:00
Ilkka Seppälä 5c26f46174 Set version number for next development iteration 2016-06-30 18:15:26 +03:00
Ilkka Seppälä 7a118e4209 Reached milestone 1.12.0 2016-06-30 18:14:41 +03:00
Ilkka Seppälä b72214da2f Fix H2 database path problem 2016-04-12 23:04:37 +03:00
Ilkka Seppälä 398eb11b11 Set version for the next development iteration 2016-04-02 19:55:04 +03:00
Ilkka Seppälä 1f27dbbf5b Set version for milestone 1.11.0 2016-04-02 19:51:03 +03:00
Narendra Pathai 464ae1690b Updated pom 2016-03-28 11:59:29 +05:30
Narendra Pathai ddbc61b140 Incorporated review changes - 1) Created sql file for central schema 2)
Changed getById return type to Optional
2016-03-28 11:55:22 +05:30
Narendra Pathai f32a3892a3 Merge branch 'master' of https://github.com/iluwatar/java-design-patterns into refactor-dao 2016-03-28 11:06:25 +05:30
Narendra Pathai 3f7ead5ca5 Work on #404, updated class diagram and javadoc. Passed checkstyle checks 2016-03-23 13:13:19 +05:30
Narendra Pathai fa077c8be9 Work on #404, javadocs and test cases for DB and in memory dao. 2016-03-21 17:55:29 +05:30
slawiko bd1b65276e all index.md files renamed to README.md for more compatibility with github 2016-03-20 11:50:21 +03:00
Narendra Pathai 448d855809 implemented and added test cases for DB dao. Added dependency of Hierarchical junit runner in parent pom 2016-03-18 16:39:45 +05:30
Narendra Pathai f6a20c7693 Refactoring changes to DAO pattern. Renamed default dao implementation to InMemory and refined interface 2016-03-16 18:47:07 +05:30
Ilkka Seppälä bbd769b208 Merge pull request #386 from amitbhoraniya/master
Dao Pattern : Create object with reference to Interface
2016-02-20 18:34:47 +02:00
Amit Bhoraniya b70614efef Creating object with reference to Interface
In Dao pattern DaoImpl object is created with reference to dao interface.
2016-02-19 00:10:55 +05:30
Ilkka Seppälä 33224dd7d7 Prepare for next development iteration 2016-02-02 22:14:20 +02:00
Ilkka Seppälä 4f56f7b097 Achieved milestone 1.10.0 2016-02-02 22:11:38 +02:00
Ilkka Seppälä f08af14555 Merge pull request #364 from DevFactory/release/The-diamond-operator-should-be-used-fix-1
squid:S2293 - The diamond operator should be used
2016-02-01 22:26:43 +02:00
Ilkka Seppälä 59c32d3937 Add tests that run the examples 2016-01-31 12:09:09 +02:00
Ilkka Seppälä dc4f07eb81 Merge pull request #360 from mikulucky/MIT-Source
Pull Request for adding License Plugin and Generate #358
2016-01-30 15:10:42 +02:00
Ilkka Seppälä d24a12a9b2 Merge pull request #359 from DevFactory/release/Local-Variables-should-not-be-declared-and-then-immediately-returned-or-thrown-fix-1
squid:S1488 - Local Variables should not be declared and then immedia…
2016-01-30 14:42:05 +02:00
Mohammed Ezzat 409ff027b8 squid:S2293 - The diamond operator should be used 2016-01-29 07:33:34 +02:00
Joseph McCarthy 3d95696078 #358 Added license to all files using plugin 2016-01-27 22:20:42 +00:00
Mohammed Ezzat 4e40cc3888 squid:S1488 - Local Variables should not be declared and then immediately returned or thrown 2016-01-27 02:45:39 +02:00
Mohammed Ezzat d00bfae5ee pmd:ConsecutiveAppendsShouldReuse - Consecutive Appends Should Reuse 2016-01-26 19:58:45 +02:00
Jeroen Meulemeester 3d642cdad7 Use headings instead of bold text in index.md #238 2016-01-03 21:14:30 +01:00
Ilkka Seppala e0e51324db Set version number for next development iteration 2016-01-01 20:39:20 +02:00
Ilkka Seppala e4458c1b17 Achieved milestone 1.9.0 2016-01-01 20:37:50 +02:00
Ilkka Seppala 7ac7e3b097 Categorize and tag all patterns #213 2015-12-28 15:52:44 +02:00
Ilkka Seppala 5f033be54f Fix PMD violations #327 2015-12-27 21:21:57 +02:00
Ilkka Seppala cec9a99410 Adjust checkstyle rules. Make checkstyle fail the build when violations are found. Correct all current checkstyle violations. 2015-12-25 23:49:28 +02:00