* Remove unused member which was also causing a false positive sonar issue.
Fixes sonar issue https://sonarcloud.io/project/issues?open=AY3gHwu5DIZTZkppqVEG&id=iluwatar_java-design-patterns
* Fixes sonar issue https://sonarcloud.io/project/issues?open=AXK0OzDA-CiGJS70dLki&id=iluwatar_java-design-patterns
related to "Refactor the code of the lambda to not have multiple invocations throwing the same checked exception."
Also, updated the code to use Instant and Duration to deal with time instead of int. Added the awaitility
library to perform assertions in test which is more reliable than using Thread.sleep directly to wait for events to happen.
* checkstyle fix
* Add sneaky throws to fix sonar lint issue. This is fine as the newFile method is not being tested but instead the new SimpleFileWriter(...) is.
* The first booking needs to happen outside the assertions. Fixed other warnings
* Use records to pass around related objects instead of using a large number of
individual params, which sonar did not like.
* Checkstyle fixes
* checkstyle fixes
* Remove complexity to keep sonar happy.
* Split into different methods to reduce complexity. Could be broken down even further but currently Sonar is happy.
* Move files to correct package
* Add valid assertions to tests
* rename constants to avoid confusion
* Sonar warning related to cognitive complexity can be suppressed as the methods are quite generic and not functional enough to be separated out.
* Use constants to keep Sonar happy
* Use correct constant naming conventions
* Use correct constant naming conventions
* Use lombok to define noargsconstructor
* Use a single method to do the logging
* Remove unused constructor and redundant method
* Use a reusable method for logging
* Write real world example and in plain words for type-object pattern
* Type-Object Programmatic Example
---------
Co-authored-by: Ilkka Seppälä <iluwatar@users.noreply.github.com>
* #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve checkstyle issues
* remove FileSelectorJFrame.java to resolve checkstyle issue
* remove FileSelectorJFrame.java to resolve checkstyle issue
* remove FileSelectorJFrame.java to resolve checkstyle issue
* add refactored file with correct filename to resolve checkstyle issue
* add the test data
* change filenames from JFrame to Jframe for checkstyle
* fix code smell from sonar report
* add new testcases to improve the test coverage
* remove code smell
* Changed database implementation. Removed static objects.
* Fix Logs
* Fix 40 errors from checkstyle plugin run. 139 left))
* Fix CacheStore errors from checkstyle plugin 107 left
* Fix last errors in checkstyle.
* Fix sonar issues
* Fix issues in VALIDATE phase
* Fix Bug with mongo connection. Used "Try with resources"
* Add test
* Added docker-compose for mongo db. MongoDb db work fixed.
* Provided missing tests
* Comments to start Application with mongo.
* Fix some broken links
* Remove extra space
* Update filename
* Fix some links in localization folders
* Fix link
* Update frontmatters
* Work on patterns index page
* Work on index page
* Fixes according PR comments. Mainly Readme edits.
* fix frontmatter
* add missing png
* Update pattern index.md
* Add index.md for Chinese translation
* update image paths
* update circuit breaker image paths
* Update image paths for localizations
* add generated puml
* Add missing image
* Update img file extensions
* Update the rest of the EN and ZH patterns to conform with the new website
Co-authored-by: Victor Zalevskii <zvictormail@gmail.com>
* Fix languages
* Missed change for version number
* Add language field for presentation
* Revert change in README for double buffer
Co-authored-by: Jackie Nim <=>
* Adding support for maven assembly plugin to generate executable jar with all dependencies in built
* Merge branch 'master' into issue-989
# Conflicts:
# abstract-document/pom.xml
# pom.xml
* Adding maven assemly plugin for projects with name A
* Update in format as per checkstyle, i.e. Spcae in place of tab with size of 2
* batch set - 2 having all project with B and C
* issue-989 d-e-f
* fixing eip pom and adding g-h-i-l-m-n Skipping naked object as it seems it doesn't have main method, will consider this at end
* Adding for O and P projects Skipping Object-Mother as we don't have main method for same.
* Final batch
* Add custom license header style in order to comply with Google's Checkstyle format
* Update license headers to comply with Google's Checkstyle format
* "visitor" pattern: Use local variable type inference
Update "visitor" pattern with local variable type inference.
* "value-object" pattern: Use local variable type inference
Update "value-object" pattern with local variable type inference.
* "unit-of-work" pattern: Use local variable type inference
Update "value-object" pattern with local variable type inference.
* "typeobjectpattern" pattern: Use local variable type inference
Update "value-object" pattern with local variable type inference.
The two remaining files were still creating a Random everytime the method
was called. These were missed in the previous commit because the previous
commit had fixed only one of the methods; in other words, there were
multiple methods that were creating the Random object on each call.
* 1011: Added SuppressWarnings for SonarCloud errors
All of these files are causing SonarCloud to report the following error:
Loops should not be infinite
Since these instances all require an infinite loop that will never end,
these warnings should be disabled so that SonarCloud no longer reports
them as error.
The rule is: squid:S2189
* 1011: Made all of the randoms static and final
According to SonarCloud rule: "Random" objects should be reused, randoms
should not be recreated. This commit has taken all of the Randoms and made
them constant variables in the files that are using them.
* #496 Add pipeline module to parent pom ✨
* #496: Add main application class and test for pipeline
* #496: Checkstyle format and add log messages on pipeline stages 🎨
* #496: Fill readme sections of pipeline ✨
* #496: Javadocs and checkstyle formatting 🎨
* #496: Follow PMD checks and add more explanation as block comment on App.java
* #496: Apply requested PR changes by iluwatar 🎨
* #970: Replace log4j usage on commander pattern to Slf4j API 🎨
* #970: Replace log4j usage on dao pattern to Slf4j API 🎨
* #970: Replace log4j usage on data mapper pattern to Slf4j API 🎨
* #970: Remove log4j dependency on data transfer object pom 🔥
* #970: Replace log4j usage on module pattern to Slf4j API 🎨
* #970: Replace log4j usage on serverless pattern to Slf4j API 🎨
This also removes the aws log4j dependency
* #970: Remove unnecessary gitignore line for log4j.xml 🔥
* #970: Remove remaining remnants of log4j 🔥
* #970: Replace System.out logging with appropriate logging methods 🎨
* #970: Replace System.out method references to Logger::info 🎨
k1w1dev