tiennm99/java-design-patterns
1
0
Fork 0
mirror of https://github.com/tiennm99/java-design-patterns.git synced 2026-05-14 22:58:36 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,339 Commits 2 Branches 0 Tags
a416b2d69137dfd6a2b64bb47f9cc41ca74052c9
Commit Graph

48 Commits

Author SHA1 Message Date
Robert Volkmann 465a6871b2 dependencies: Upgrade mockito 3.5 to 4.5 (#2316) 
* refactor: move tests of leader-followers into correct package

* dep: remove version constraint for Mockito in acyclic-visitor

* dep: remove version constraint for Mockito in caching

* chore: cleanup mockito-core import on some POMs

* dep: upgrade core.mocktio 3.5.6 to 4.5.1

"- org.mockito.Mockito#verifyZeroInteractions an alias of verifyNoMoreInteractions"
https://github.com/mockito/mockito/commit/caf35b24e2764df0498469526ecb3e7ec68a0430
 2022-11-20 10:16:53 +02:00
Robert Volkmann 4cd8149502 refactor: remove code smell java:S5786 (#2159) 
https://sonarcloud.io/organizations/iluwatar/rules?open=java%3AS5786&rule_key=java%3AS5786
 2022-10-30 18:21:21 +02:00
Ilkka Seppälä 932836f68b Update license plugin (#2020) 
* update license plugin

* suppress linelength and emptylineseparator rules

* fix checkstyle error

Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
 2022-09-14 23:22:24 +05:30
Victor 73eca64b9f refactoring: Issue-1694: Improve caching pattern code quality (#1810) 
* Changed database implementation. Removed static objects.

* Fix Logs

* Fix 40 errors from checkstyle plugin run. 139 left))

* Fix CacheStore errors from checkstyle plugin 107 left

* Fix last errors in checkstyle.

* Fix sonar issues

* Fix issues in VALIDATE phase

* Fix Bug with mongo connection. Used "Try with resources"

* Add test

* Added docker-compose for mongo db. MongoDb db work fixed.

* Provided missing tests

* Comments to start Application with mongo.

* Fixes according PR comments. Mainly Readme edits.

* Remove duplicated imports
 2021-10-20 20:44:01 +03:00
Simran Keshri 5a644f1092 refactoring: Critical Sonar Issues (#1833) 
* Resolve Sonar Code Smell: Define a constant instead of duplicating this literal 'Space rocket <' 4 times.

* Resolve Sonar Critical Code Smell: Define a constant instead of duplicating this literal 'Error connecting to MongoDB' 4 times.

* Fix checkstyle violation.

* Resolve Sonar Critical Code Smell: Define a constant instead of duplicating this literal 'LITERAL 0' 4 times.

Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
 2021-10-13 13:15:22 +05:30
Ilkka Seppälä eb8f9db575 #590 add explanation for caching pattern (#1693) 
Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
 2021-03-28 16:32:29 +05:30
va1m 5cf2fe009b 📍Use lombok, reformat, and optimize the code (#1560) 
* Use lombok, reformat, and optimize the code

* Fix merge conflicts and some sonar issues

Co-authored-by: va1m <va1m@email.com>
 2021-03-13 14:19:21 +02:00
Subhrodip Mohanta 7891c2b117 update inception year to 2021 (#1653) 2021-02-14 11:57:57 +02:00
Subhrodip Mohanta 3f09fb70bb Clear Sonar Blockers (#1643) 
* remove debt from CachingTest

https://sonarcloud.io/project/issues?fileUuids=AW3G0SevwB6UiZzQNqXR&id=iluwatar_java-design-patterns&open=AXK0Ozo--CiGJS70dLl0&resolved=false
 
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>

* fixed few debts for Spatial Partition module

Mainly convertig Hashtable to HashMaps

Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>

* fixed some logger norms

Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>

* fixed few errors as it got mixed with the stash

Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
 2021-01-30 13:37:52 +02:00
Toxic Dreamz 31471acb69 Fixed most reported issues by SonarCloud. 2020-08-15 21:47:39 +04:00
Ilkka Seppälä 417f21ed3d Code cleanup (#1461) 
* Code cleanup

* Fix flux tests

* Fix checkstyle errors

* Fix compile error
 2020-07-30 20:28:47 +03:00
Anurag Agarwal 33ea7335b1 Java 11 migration: patterns (remaining b-c) (#1081) 
* Moves business-delegate pattern  to java 11

* Moves bytecode pattern  to java 11

* Moves caching pattern  to java 11

* Moves callback pattern  to java 11

* Moves chain pattern  to java 11

* Moves circuit-breaker pattern  to java 11

* Moves collection-pipeline pattern  to java 11

* Moves command pattern  to java 11

* Moves commander pattern  to java 11

* Moves composite pattern  to java 11

* Corrects test cases
 2019-11-12 21:56:46 +02:00
Anurag Agarwal efc17fcc70 Resolves checkstyle errors for business-delegate, bytecode, caching (#1059) 
* Reduces checkstyle errors in business-delegate

* Reduces checkstyle errors in bytecode

* Reduces checkstyle errors in caching
 2019-11-09 21:23:12 +02:00
Alexander Ivanov 4904d7eea0 #1021: Fix checkstyle warnings by changing the license header template (#1027) 
* Add custom license header style in order to comply with Google's Checkstyle format

* Update license headers to comply with Google's Checkstyle format
 2019-10-22 08:15:35 +03:00
Ilkka Seppälä 9ebbc421dd Update license headers 2019-10-12 20:05:54 +03:00
Per Wramdemark 218ba44dbf Upgrade of maven plugins (#951) 
* Upgrade maven plugins

* Upgrade maven plugins

Some general code cleanup was necessary due to upgrade of PMD and checkstyle.

Also needed to add Junit 4 as a dependency due to Mockito.timout issue found here:
https://github.com/mockito/mockito/issues/152
 2019-10-05 14:23:20 +03:00
Ilkka Seppälä a113de6a14 Add licenses 2019-07-28 16:24:14 +03:00
kanwarpreet25 c6ecf58687 508 : sonar qube critical issue fixes (#852) 
* 508 : sonar qube critical issue fixes

* 508 : Sunar Qube Fixes
Define a constant instead of duplicating this literal "user_accounts" 4 times.
Define a constant instead of duplicating this literal "userID" 5 times
Define a constant instead of duplicating this literal "additionalInfo" 4 times.
Define a constant instead of duplicating this literal "userName" 4 times.

* 508 : Sunar Qube Fixes
Define a constant instead of duplicating this literal "user_accounts" 4 times.

* 508 : Sonar Qube Fixes
Define a constant instead of duplicating this literal "eEvans" 4 times
Define a constant instead of duplicating this literal "jBloch" 6 times
Define a constant instead of duplicating this literal "mFowler" 3 times

* 508 : Sonar Qube FIxes
Define a constant instead of duplicating this literal "username" 3 times.

* 508: sonar qube issue fixes
Define a constant instead of duplicating this literal "customerDao.getAllCustomers(): " 4 times.

* 508 : sonar qube issue fixes
Define a constant instead of duplicating this literal "App.main(), student : " 4 times.

* 508 : sonar Qube issue fixes
Define a constant instead of duplicating this literal "{} hits {}. {} is damaged!" 3 times.
Define a constant instead of duplicating this literal "{} hits {}." 4 times.

* 508 : Define a constant instead of duplicating this literal "{} hits {}." 4 times.

* 508 : checkstyle fixes

* 508: checkstyle fixes

* 508: checkstyle fixes

* 508: checkstyle fixes

* 508: checkstyle fixes

* 508: checkstyle fixes

* 508: cqrs checkstyle fixes
 2019-07-28 15:39:40 +03:00
baislsl 991ba320a6 Improve Javadoc 2018-02-19 22:01:14 +08:00
Artur Mogozov 6694d742a3 Migrate to JUnit5 2017-12-31 16:29:48 +09:00
leogtzr d6fc28e120 Changing code to use interfaces instead of implementations. 2017-01-21 15:47:54 -07:00
Ilkka Seppälä faa29f8025 Update license headers 2016-11-27 14:34:20 +02:00
daniel-bryla b37190a214 #502 Introduced logging in new example 2016-11-04 12:19:32 +01:00
daniel-bryla 0a427710bb Merge branch 'master' of https://github.com/iluwatar/java-design-patterns 
* 'master' of https://github.com/iluwatar/java-design-patterns: (27 commits)
  Remove use of coveralls-maven-plugin (sonarqube.com covers this)
  Add SonarQube.com badge
  Fix environment variable
  Add Travis instructions for SonarQube.com analysis
  Adds more criticism to Singleton pattern.
  Event Based Asynchronous pattern: Add missing license header and puml diagram
  Changed config to non-interactive
  Moved config into a separate dir
  Unused import removed.
  End process logic clause has been corrected.
  Caching pattern: Documentation and diagram
  Fixes #437. Adds criticism to Singleton pattern.
  Alter JUnit tests to run in lesser time.
  Updated version snapshot to 1.14.0
  Changes based on review feedback.
  Closes #436. Adds criticism to service locator pattern.
  Caching pattern: Implementation of Cache-Aside pattern
  Caching pattern: Style fix for null check
  Caching pattern: Refactor LRU cache to avoid NPE and unnecessary cache lookup
  Caching pattern: Refactor shutdown hook to use method reference
  ...
 2016-11-04 11:51:45 +01:00
daniel-bryla 0438811489 #502 Replaced usages of System.out with logger. 2016-10-23 19:59:03 +02:00
Christoffer Hamberg f114b5b957 Caching pattern: Documentation and diagram 2016-10-09 12:43:43 +02:00
Christoffer Hamberg b31edda3cf Caching pattern: Implementation of Cache-Aside pattern 2016-09-22 20:41:26 +02:00
Christoffer Hamberg e3355d76d1 Caching pattern: Style fix for null check 2016-09-22 20:36:02 +02:00
Christoffer Hamberg 865f788612 Caching pattern: Refactor LRU cache to avoid NPE and unnecessary cache lookup 2016-09-22 20:35:44 +02:00
Christoffer Hamberg 6ed842e58b Caching pattern: Refactor shutdown hook to use method reference 2016-09-22 20:34:46 +02:00
Mohammed Ezzat e4c34b1e22 squid:S1319 - Declarations should use Java collection interfaces such as List rather than specific implementation classes such as LinkedList 2016-02-23 12:32:23 +02:00
Narendra Pathai dfef28e93e Merge pull request #384 from DevFactory/release/Redundant-Field-Initializer-fix-1 
pmd:RedundantFieldInitializer - Redundant-Field-Initializer
 2016-02-18 12:39:06 +05:30
Mohammed Ezzat 0003c6cb00 pmd:RedundantFieldInitializer - Redundant-Field-Initializer 2016-02-18 08:40:19 +02:00
Mohammed Ezzat 632174b6dc squid:S2974 - Classes without public constructors should be final 2016-02-09 17:19:31 +02:00
Ilkka Seppälä f08af14555 Merge pull request #364 from DevFactory/release/The-diamond-operator-should-be-used-fix-1 
squid:S2293 - The diamond operator should be used
 2016-02-01 22:26:43 +02:00
Ilkka Seppälä 59c32d3937 Add tests that run the examples 2016-01-31 12:09:09 +02:00
Ilkka Seppälä dc4f07eb81 Merge pull request #360 from mikulucky/MIT-Source 
Pull Request for adding License Plugin and Generate #358
 2016-01-30 15:10:42 +02:00
Mohammed Ezzat 409ff027b8 squid:S2293 - The diamond operator should be used 2016-01-29 07:33:34 +02:00
Joseph McCarthy 3d95696078 #358 Added license to all files using plugin 2016-01-27 22:20:42 +00:00
Mohammed Ezzat 4e40cc3888 squid:S1488 - Local Variables should not be declared and then immediately returned or thrown 2016-01-27 02:45:39 +02:00
Kirill Vlasov c8a750df49 Fixing squid:S1118 - Utility classes should not have public constructors 2015-12-27 21:17:13 +05:00
Ilkka Seppälä 3d8c64d76d Merge pull request #322 from DevFactory/dead-stores-fix-1 
Fixing squid:S1854 - Dead stores should be removed
 2015-12-26 13:38:16 +02:00
Ilkka Seppala cec9a99410 Adjust checkstyle rules. Make checkstyle fail the build when violations are found. Correct all current checkstyle violations. 2015-12-25 23:49:28 +02:00
Kirill Vlasov 6e496e7c86 Fixing squid:S1854 - Dead stores should be removed 2015-12-23 13:41:38 +05:00
waisuan 998ba7e6e0 Issue #273: Fixed HTML tags in comments 2015-11-02 02:11:58 +08:00
waisuan 6418a6c2b6 Issue #273: Fixed issues based on review remarks 2015-11-02 01:40:38 +08:00
waisuan d0f5009996 Issue #273: Changed DB to internal Java data structure to avoid compilation errors + decrease in code coverage 2015-10-29 00:57:41 +08:00
waisuan 9891c2e17b Issue #273:Caching Patterns [new pattern] 2015-10-28 23:55:47 +08:00