Commit Graph

6 Commits

Author SHA1 Message Date
Ilkka Seppälä 0ca162a55c deps: Refactor dependencies (#3224)
* remove spring dep
move junit, logging, mockito under dep mgmt

* upgrade anti-corruption-layer deps

* async method invocation

* balking, bloc

* bridge to bytecode

* caching

* callback - cqrs

* component - health check

* hexagonal - metadata mapping

* rest of the patterns

* remove checkstyle, take spotless into use
2025-03-29 19:34:27 +02:00
k1w1dev ef42e169b9 fix: Fix sonar issues (#2925)
* Remove unused member which was also causing a false positive sonar issue.
Fixes sonar issue https://sonarcloud.io/project/issues?open=AY3gHwu5DIZTZkppqVEG&id=iluwatar_java-design-patterns

* Fixes sonar issue https://sonarcloud.io/project/issues?open=AXK0OzDA-CiGJS70dLki&id=iluwatar_java-design-patterns
related to "Refactor the code of the lambda to not have multiple invocations throwing the same checked exception."

Also, updated the code to use Instant and Duration to deal with time instead of int. Added the awaitility
library to perform assertions in test which is more reliable than using Thread.sleep directly to wait for events to happen.

* checkstyle fix

* Add sneaky throws to fix sonar lint issue. This is fine as the newFile method is not being tested but instead the new SimpleFileWriter(...) is.

* The first booking needs to happen outside the assertions. Fixed other warnings

* Use records to pass around related objects instead of using a large number of
individual params, which sonar did not like.

* Checkstyle fixes

* checkstyle fixes

* Remove complexity to keep sonar happy.

* Split into different methods to reduce complexity. Could be broken down even further but currently Sonar is happy.

* Move files to correct package

* Add valid assertions to tests

* rename constants to avoid confusion

* Sonar warning related to cognitive complexity can be suppressed as the methods are quite generic and not functional enough to be separated out.

* Use constants to keep Sonar happy

* Use correct constant naming conventions

* Use correct constant naming conventions

* Use lombok to define noargsconstructor

* Use a single method to do the logging

* Remove unused constructor and redundant method

* Use a reusable method for logging
2024-05-04 08:20:01 +03:00
Ilkka Seppälä 7c1889b8e5 refactor: update layers parent, reformat code, update license headers 2024-03-30 08:34:54 +02:00
akshatarora0013 9d6ae392b8 refactoring: issue#2376 (#2491)
Changed all the switch expression according to the JAVA 17.
2023-04-01 17:48:38 +03:00
Rahul Raj fb7ec9b375 dependencies: #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve chec… (#2464)
* #2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve checkstyle issues

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* remove FileSelectorJFrame.java to resolve checkstyle issue

* add refactored file with correct filename to resolve checkstyle issue

* add the test data

* change filenames from JFrame to Jframe for checkstyle

* fix code smell from  sonar report

* add new testcases to improve the test coverage

* remove code smell
2023-02-04 19:20:54 +02:00
JanFidor fb86ca1156 feature: #2151 Feature/mvi pattern (#2177)
* #2151 add module and pom.xml

* #2151 add Calculator Actions

* #2151 add remaining mvi pattern classes (actions already implemented)

* #2151 add Main and unit tests

* add README.md and class diagrams

* #2151 add module and pom.xml

* #2151 add Calculator Actions

* #2151 add remaining mvi pattern classes (actions already implemented)

* #2151 add Main and unit tests

* add README.md and class diagrams

* fixes for lint errors

* #2151 add module and pom.xml

* #2151 add Calculator Actions

* #2151 add remaining mvi pattern classes (actions already implemented)

* #2151 add Main and unit tests

* add README.md and class diagrams

* fixes for lint errors

* use Lombok @Data decorator and decouple View from ViewModel

* add comments and documentation

* fix checkstyle, the smart switch syntax was breaking checkstyle, so I had to change it back
2023-01-21 11:45:07 +02:00