Commit Graph

8 Commits

Author SHA1 Message Date
Ilkka Seppälä 584e949714 docs: updates to several patterns 2024-05-28 19:46:39 +03:00
Ilkka Seppälä eb6da7397d docs: update page controller 2024-05-26 21:40:11 +03:00
Ilkka Seppälä a766f188a8 docs: explanation for reactor (#2960) 2024-05-18 12:05:33 +03:00
Ilkka Seppälä a878938544 docs: update page controller 2024-05-15 11:13:49 +03:00
k1w1dev ef42e169b9 fix: Fix sonar issues (#2925)
* Remove unused member which was also causing a false positive sonar issue.
Fixes sonar issue https://sonarcloud.io/project/issues?open=AY3gHwu5DIZTZkppqVEG&id=iluwatar_java-design-patterns

* Fixes sonar issue https://sonarcloud.io/project/issues?open=AXK0OzDA-CiGJS70dLki&id=iluwatar_java-design-patterns
related to "Refactor the code of the lambda to not have multiple invocations throwing the same checked exception."

Also, updated the code to use Instant and Duration to deal with time instead of int. Added the awaitility
library to perform assertions in test which is more reliable than using Thread.sleep directly to wait for events to happen.

* checkstyle fix

* Add sneaky throws to fix sonar lint issue. This is fine as the newFile method is not being tested but instead the new SimpleFileWriter(...) is.

* The first booking needs to happen outside the assertions. Fixed other warnings

* Use records to pass around related objects instead of using a large number of
individual params, which sonar did not like.

* Checkstyle fixes

* checkstyle fixes

* Remove complexity to keep sonar happy.

* Split into different methods to reduce complexity. Could be broken down even further but currently Sonar is happy.

* Move files to correct package

* Add valid assertions to tests

* rename constants to avoid confusion

* Sonar warning related to cognitive complexity can be suppressed as the methods are quite generic and not functional enough to be separated out.

* Use constants to keep Sonar happy

* Use correct constant naming conventions

* Use correct constant naming conventions

* Use lombok to define noargsconstructor

* Use a single method to do the logging

* Remove unused constructor and redundant method

* Use a reusable method for logging
2024-05-04 08:20:01 +03:00
Jun Kang 8471c93035 deps: Updated the maven imports of page-controller pattern for SpringBoot 3.2.4 (#2862)
* Updated the imports in code of the single table inheritance pattern for Spring Boot 3.x

#2825
Change javax library to jakarta

* add pom.xml

* Updated the imports in code of the healthcheck pattern for SpringBoot 3.x

Change javax library to jakarta and update maven dependency versions

* change order of imports to pass Checkstyle violations

* change import order to pass lexicographical order test

* change import order to pass CustomImportOrder warning

* Updated the maven imports of layers pattern for SpringBoot 3.2.4

* remove unused maven import

* Updated the maven imports of page-controller pattern for SpringBoot 3.2.4

- add page-controller module on parent pom.xml
- add artifact information on page-controller pom.xml
- add Springboot3, proper test dependencies on page-controller pom.xml
2024-03-30 13:58:18 +02:00
Ilkka Seppälä 8877ba70d3 fix: Fix context object (#2415)
* fix pr builder goals

* update links

* add context-object to build

* add autogenerated content

* fix checkstyle findings
2023-01-01 12:28:51 +02:00
marikattt 4709922f11 feature: add Page Controller pattern (#2202)
* feat: create page controller

* add test

* add documentation

* fix: delete img file

* fix: modify App, SignupMode, UserController, pom.xml, and Readme

* fix: modify MVC files on page controller

* fix: modify readme file
2023-01-01 10:57:30 +02:00