Narendra Pathai 37ae182630 Resolved PMD issues

2018-10-15 13:30:20 +05:30

..

main/java/com/iluwatar/hexagonal

Resolved PMD issues

2018-10-15 13:30:20 +05:30

test/java/com/iluwatar/hexagonal

1) Refactored LotteryNumbers to use Joiner from guava library to join lottery numbers. 2) Solved potential thread safety issue in LotteryTicketId class, where it was using raw primitive value and incrementing it which is not thread-safe. So used AtomicInteger for brevity 3) assertEquals arguments were in incorrect order at many places, so changed order of those 4) Replaced assertFalse and assertTrue at some places with assertEquals and assertNotEquals for reducing complexity of code 5) Removed public modifiers from test cases, as they are no more needed by JUnit 5

2018-10-15 13:21:00 +05:30