From 76e1b2c015647df60e81faf2bbcb7e2aab25f14c Mon Sep 17 00:00:00 2001 From: Julio Quinteros Pro Date: Sun, 15 Feb 2026 12:21:51 -0300 Subject: [PATCH] Remove redundant sys.modules cleanup in Langfuse test tearDown The manual sys.modules restoration code was redundant because patch.dict.stop() automatically handles the cleanup. This simplifies the tearDown method and removes the now-unused _original_langfuse_module instance variable. Addresses review comment: https://github.com/BerriAI/litellm/pull/21214#pullrequestreview-3802348462 Co-Authored-By: Claude Sonnet 4.5 --- tests/test_litellm/integrations/test_langfuse.py | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/tests/test_litellm/integrations/test_langfuse.py b/tests/test_litellm/integrations/test_langfuse.py index 84dfbaf638..65a4882882 100644 --- a/tests/test_litellm/integrations/test_langfuse.py +++ b/tests/test_litellm/integrations/test_langfuse.py @@ -32,9 +32,6 @@ class TestLangfuseUsageDetails(unittest.TestCase): ) self.env_patcher.start() - # Store original langfuse module if it exists for cleanup - self._original_langfuse_module = sys.modules.get("langfuse") - # Create mock objects self.mock_langfuse_client = MagicMock() # Mock the client attribute to prevent errors during logger initialization @@ -127,13 +124,7 @@ class TestLangfuseUsageDetails(unittest.TestCase): def tearDown(self): self.env_patcher.stop() - self.langfuse_module_patcher.stop() - - # Restore original langfuse module or remove mock to prevent test pollution - if self._original_langfuse_module is not None: - sys.modules["langfuse"] = self._original_langfuse_module - elif "langfuse" in sys.modules: - del sys.modules["langfuse"] + self.langfuse_module_patcher.stop() # patch.dict automatically restores sys.modules def test_langfuse_usage_details_type(self): """Test that LangfuseUsageDetails TypedDict is properly defined with the correct fields"""