From 898cc3ff4ff1a911b772bc04eec2dc3a8f3d9e54 Mon Sep 17 00:00:00 2001 From: Yuta Saito Date: Thu, 22 Jan 2026 06:19:43 +0900 Subject: [PATCH] test: update langfuse trace_id tests to use litellm_trace_id --- tests/litellm_utils_tests/test_utils.py | 4 ++-- tests/logging_callback_tests/test_alerting.py | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/litellm_utils_tests/test_utils.py b/tests/litellm_utils_tests/test_utils.py index e1751c8e2f..f585aadbfc 100644 --- a/tests/litellm_utils_tests/test_utils.py +++ b/tests/litellm_utils_tests/test_utils.py @@ -973,11 +973,11 @@ def test_logging_trace_id(langfuse_trace_id, langfuse_existing_trace_id): litellm_logging_obj._get_trace_id(service_name="langfuse") == langfuse_trace_id ) - ## if existing_trace_id exists + ## if no trace_id or existing_trace_id is provided, use litellm_trace_id else: assert ( litellm_logging_obj._get_trace_id(service_name="langfuse") - == litellm_call_id + == litellm_logging_obj.litellm_trace_id ) diff --git a/tests/logging_callback_tests/test_alerting.py b/tests/logging_callback_tests/test_alerting.py index 8a691e7618..524cc00d5f 100644 --- a/tests/logging_callback_tests/test_alerting.py +++ b/tests/logging_callback_tests/test_alerting.py @@ -866,11 +866,9 @@ async def test_langfuse_trace_id(): assert trace_url is not None - returned_trace_id = int(trace_url.split("/")[-1]) + returned_trace_id = trace_url.split("/")[-1] - assert returned_trace_id == int( - litellm_logging_obj._get_trace_id(service_name="langfuse") - ) + assert returned_trace_id == litellm_logging_obj._get_trace_id(service_name="langfuse") @pytest.mark.asyncio