From 0b1b73e23a92bb727cf73e8a1d5345fa12c9dc34 Mon Sep 17 00:00:00 2001 From: coconut49 Date: Tue, 24 Oct 2023 12:37:07 +0800 Subject: [PATCH 1/4] Update Docker workflow to convert repository name to lowercase --- .github/workflows/docker.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 616ba5c9f9..cb97331969 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -24,15 +24,15 @@ jobs: id: meta uses: docker/metadata-action@v5 with: - images: ghcr.io/${{ github.repository }} + images: ghcr.io/${{ github.repository,, }} - name: Get tag to build id: tag run: | - echo "latest=ghcr.io/${{ github.repository }}:latest" >> $GITHUB_OUTPUT + echo "latest=ghcr.io/${{ github.repository,, }}:latest" >> $GITHUB_OUTPUT if [[ -z "${{ github.event.inputs.tag }}" ]]; then - echo "versioned=ghcr.io/${{ github.repository }}:${{ github.ref_name }}" >> $GITHUB_OUTPUT + echo "versioned=ghcr.io/${{ github.repository,, }}:${{ github.ref_name }}" >> $GITHUB_OUTPUT else - echo "versioned=ghcr.io/${{ github.repository }}:${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT + echo "versioned=ghcr.io/${{ github.repository,, }}:${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT fi - name: Build and release Docker images uses: docker/build-push-action@v5 From 33bbeaa397e0daacf800f51d48af438beff75c1f Mon Sep 17 00:00:00 2001 From: coconut49 Date: Tue, 24 Oct 2023 12:42:04 +0800 Subject: [PATCH 2/4] Implement lower case transformation for repository name in Docker workflow --- .github/workflows/docker.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index cb97331969..b906230e6d 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -20,19 +20,24 @@ jobs: registry: ghcr.io username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} + - name: set lower case repository name + run: | + echo "REPOSITORY_LC=${REPOSITORY,,}" >>${GITHUB_ENV} + env: + REPOSITORY: '${{ github.repository }}' - name: Extract metadata (tags, labels) for Docker id: meta uses: docker/metadata-action@v5 with: - images: ghcr.io/${{ github.repository,, }} + images: ghcr.io/${{ REPOSITORY_LC }} - name: Get tag to build id: tag run: | - echo "latest=ghcr.io/${{ github.repository,, }}:latest" >> $GITHUB_OUTPUT + echo "latest=ghcr.io/${{ REPOSITORY_LC }}:latest" >> $GITHUB_OUTPUT if [[ -z "${{ github.event.inputs.tag }}" ]]; then - echo "versioned=ghcr.io/${{ github.repository,, }}:${{ github.ref_name }}" >> $GITHUB_OUTPUT + echo "versioned=ghcr.io/${{ REPOSITORY_LC }}:${{ github.ref_name }}" >> $GITHUB_OUTPUT else - echo "versioned=ghcr.io/${{ github.repository,, }}:${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT + echo "versioned=ghcr.io/${{ REPOSITORY_LC }}:${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT fi - name: Build and release Docker images uses: docker/build-push-action@v5 From 0e34820ffee6f2ed3f15257f449c77988cbc83e3 Mon Sep 17 00:00:00 2001 From: coconut49 Date: Tue, 24 Oct 2023 12:53:20 +0800 Subject: [PATCH 3/4] Refactor Docker workflow to remove unnecessary curly braces in variable references. --- .github/workflows/docker.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index b906230e6d..566ebcf12b 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -29,15 +29,15 @@ jobs: id: meta uses: docker/metadata-action@v5 with: - images: ghcr.io/${{ REPOSITORY_LC }} + images: ghcr.io/${ REPOSITORY_LC } - name: Get tag to build id: tag run: | - echo "latest=ghcr.io/${{ REPOSITORY_LC }}:latest" >> $GITHUB_OUTPUT + echo "latest=ghcr.io/${ REPOSITORY_LC }:latest" >> $GITHUB_OUTPUT if [[ -z "${{ github.event.inputs.tag }}" ]]; then - echo "versioned=ghcr.io/${{ REPOSITORY_LC }}:${{ github.ref_name }}" >> $GITHUB_OUTPUT + echo "versioned=ghcr.io/${ REPOSITORY_LC }:${{ github.ref_name }}" >> $GITHUB_OUTPUT else - echo "versioned=ghcr.io/${{ REPOSITORY_LC }}:${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT + echo "versioned=ghcr.io/${ REPOSITORY_LC }:${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT fi - name: Build and release Docker images uses: docker/build-push-action@v5 From 587b80863178b5ecc081767b5055c132aaf796bf Mon Sep 17 00:00:00 2001 From: coconut49 Date: Tue, 24 Oct 2023 13:30:11 +0800 Subject: [PATCH 4/4] Refactor Docker workflow to use REPO_NAME environment variable --- .github/workflows/docker.yml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 566ebcf12b..4fa42a46e8 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -7,7 +7,11 @@ on: jobs: build: runs-on: ubuntu-latest + env: + REPO_NAME: ${{ github.repository }} steps: + - name: Convert repo name to lowercase + run: echo "REPO_NAME=$(echo "$REPO_NAME" | tr '[:upper:]' '[:lower:]')" >> $GITHUB_ENV - name: Checkout uses: actions/checkout@v4 - name: Set up QEMU @@ -20,24 +24,19 @@ jobs: registry: ghcr.io username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} - - name: set lower case repository name - run: | - echo "REPOSITORY_LC=${REPOSITORY,,}" >>${GITHUB_ENV} - env: - REPOSITORY: '${{ github.repository }}' - name: Extract metadata (tags, labels) for Docker id: meta uses: docker/metadata-action@v5 with: - images: ghcr.io/${ REPOSITORY_LC } + images: ghcr.io/${{ env.REPO_NAME }} - name: Get tag to build id: tag run: | - echo "latest=ghcr.io/${ REPOSITORY_LC }:latest" >> $GITHUB_OUTPUT + echo "latest=ghcr.io/${{ env.REPO_NAME }}:latest" >> $GITHUB_OUTPUT if [[ -z "${{ github.event.inputs.tag }}" ]]; then - echo "versioned=ghcr.io/${ REPOSITORY_LC }:${{ github.ref_name }}" >> $GITHUB_OUTPUT + echo "versioned=ghcr.io/${{ env.REPO_NAME }}:${{ github.ref_name }}" >> $GITHUB_OUTPUT else - echo "versioned=ghcr.io/${ REPOSITORY_LC }:${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT + echo "versioned=ghcr.io/${{ env.REPO_NAME }}:${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT fi - name: Build and release Docker images uses: docker/build-push-action@v5