From bdb995f436de3c342713998bb694c1be35feaede Mon Sep 17 00:00:00 2001 From: Marc Abramowitz Date: Mon, 13 May 2024 16:49:36 -0700 Subject: [PATCH] Revert `= None` changes because @krrishdholakia said [here](https://github.com/BerriAI/litellm/pull/3600#discussion_r1599108453) that they were problematic in the past. --- litellm/integrations/slack_alerting.py | 2 +- litellm/tests/test_streaming.py | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/litellm/integrations/slack_alerting.py b/litellm/integrations/slack_alerting.py index 34199d6b6e..b06a229208 100644 --- a/litellm/integrations/slack_alerting.py +++ b/litellm/integrations/slack_alerting.py @@ -48,7 +48,7 @@ class DeploymentMetrics(LiteLLMBase): failed_request: bool """did it fail the request?""" - latency_per_output_token: Optional[float] = None + latency_per_output_token: Optional[float] """latency/output token of deployment""" updated_at: dt diff --git a/litellm/tests/test_streaming.py b/litellm/tests/test_streaming.py index eb9aa310cc..a948a5683a 100644 --- a/litellm/tests/test_streaming.py +++ b/litellm/tests/test_streaming.py @@ -2214,15 +2214,15 @@ class ToolCalls(BaseModel): class Delta(BaseModel): role: str - content: Optional[str] = None + content: Optional[str] tool_calls: List[ToolCalls] class Choices(BaseModel): index: int delta: Delta - logprobs: Optional[str] = None - finish_reason: Optional[str] = None + logprobs: Optional[str] + finish_reason: Optional[str] class Chunk(BaseModel): @@ -2276,7 +2276,7 @@ class Function2(BaseModel): class ToolCalls2(BaseModel): index: int - function: Optional[Function2] = None + function: Optional[Function2] class Delta2(BaseModel): @@ -2286,8 +2286,8 @@ class Delta2(BaseModel): class Choices2(BaseModel): index: int delta: Delta2 - logprobs: Optional[str] = None - finish_reason: Optional[str] = None + logprobs: Optional[str] + finish_reason: Optional[str] class Chunk2(BaseModel): @@ -2341,7 +2341,7 @@ class Delta3(BaseModel): class Choices3(BaseModel): index: int delta: Delta3 - logprobs: Optional[str] = None + logprobs: Optional[str] finish_reason: str