Enable OpenTelemetry context propagation by external tracers (#15940)

* Fix: Enable OpenTelemetry context propagation with external tracers * Add test for handling external tracers * change priority to get tracer --------- Co-authored-by: eycjur <eycjur@example.com>
2026-06-17 22:48:35 +00:00 · 2025-10-27 02:09:54 +09:00
parent a75e75ae1a
commit d8b44f4dbf
3 changed files with 131 additions and 15 deletions
@@ -56,3 +56,66 @@ class TestOpentelemetryUnitTests(BaseLoggingCallbackTest):
        await asyncio.sleep(1)

        parent_otel_span.end.assert_called_once()
+
+    def test_init_tracing_respects_existing_tracer_provider(self):
+        """
+        Unit test: _init_tracing() should respect existing TracerProvider.
+
+        When a TracerProvider already exists (e.g., set by Langfuse SDK),
+        LiteLLM should use it instead of creating a new one.
+        """
+        from opentelemetry import trace
+        from opentelemetry.sdk.trace import TracerProvider
+        from litellm.integrations.opentelemetry import OpenTelemetry
+
+        # Setup: Create and set an existing TracerProvider
+        tracer_provider = TracerProvider()
+        trace.set_tracer_provider(tracer_provider)
+        existing_provider = trace.get_tracer_provider()
+
+        # Act: Initialize OpenTelemetry integration (should detect existing provider)
+        otel_integration = OpenTelemetry()
+
+        # Assert: The existing provider should still be active
+        current_provider = trace.get_tracer_provider()
+        assert current_provider is existing_provider, (
+            "Existing TracerProvider should be respected and not overridden"
+        )
+
+    def test_get_span_context_detects_active_span(self):
+        """
+        Unit test: _get_span_context() should auto-detect active spans from global context.
+
+        Active spans should be automatically detected without explicit metadata
+        """
+        from opentelemetry import trace
+        from opentelemetry.sdk.trace import TracerProvider
+        from litellm.integrations.opentelemetry import OpenTelemetry
+
+        # Setup: Create TracerProvider and tracer
+        tracer_provider = TracerProvider()
+        trace.set_tracer_provider(tracer_provider)
+        tracer = trace.get_tracer(__name__)
+
+        # Create OpenTelemetry integration
+        otel_integration = OpenTelemetry()
+
+        # Act: Create an active span and test detection
+        with tracer.start_as_current_span("test_parent") as parent_span:
+            parent_span_context = parent_span.get_span_context()
+
+            # Call _get_span_context without explicit parent in metadata
+            kwargs = {"litellm_params": {"metadata": {}}}
+            detected_context, detected_span = otel_integration._get_span_context(kwargs)
+
+            # Assert: Should detect the active span
+            assert detected_span is not None, "Should detect active span from global context"
+            assert detected_span is parent_span, "Detected span should be the active parent span"
+
+            detected_span_context = detected_span.get_span_context()
+            assert detected_span_context.trace_id == parent_span_context.trace_id, (
+                "Detected span should have same trace_id as parent"
+            )
+            assert detected_span_context.span_id == parent_span_context.span_id, (
+                "Detected span should have same span_id as parent"
+            )