mirror of
https://github.com/tiennm99/litellm.git
synced 2026-06-17 14:48:44 +00:00
Krrish Dholakia
4ed3e712e0
* fix(memory): jsonify metadata before Prisma writes on /v1/memory The POST/PUT memory endpoints handed bare dicts (and bare `None`) to prisma-client-python for the `Json?` `metadata` column, which the client rejects with `MissingRequiredValueError` / `DataError: metadata should be of any of the following types: NullableJsonNullValueInput, Json`. Both the create and upsert paths now route writes through the existing `jsonify_object` helper used elsewhere in the proxy for `Json?` columns (e.g. `LiteLLM_VerificationToken.budget_limits`), and omit metadata when None so the column defaults to SQL NULL via the schema. Explicit `metadata: null` on PUT is now a no-op for the column to match how the rest of the proxy handles nullable JSON fields (no `JsonNull`/`DbNull` sentinel exists in prisma-client-python — see RobertCraigie/prisma-client-py#714). A payload with only `metadata: null` returns 400 instead of a misleading 200. Made-with: Cursor * fix(memory): JSON-encode non-dict metadata before Prisma writes `jsonify_object` only stringifies dict values, so list-shaped metadata still hit Prisma as raw Python objects and triggered the same DataError this PR is meant to fix. `metadata` is typed `Optional[Any]` so list payloads are valid input. Replace `jsonify_object` with a local `_serialize_metadata_for_prisma` helper that always `json.dumps` non-string values, applied at all three write sites (POST create, PUT update, PUT-create). Adds regression tests for list metadata on each path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(memory): always json.dumps metadata, not just non-strings The str-passthrough in `_serialize_metadata_for_prisma` left plain Python strings (e.g. `metadata: "hello"`) unencoded — Postgres `jsonb` rejects bare-word strings as invalid JSON, reproducing the same DataError this PR is meant to fix. Always `json.dumps` regardless of input type so all `Optional[Any]` shapes (dict, list, scalar, str) become valid JSON. Adds a regression test for plain-string metadata. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(memory): encode explicit metadata:null as JSON null to clear field prisma-client-python has no JsonNull/DbNull sentinel for writing a true SQL NULL on `Json?` columns (RobertCraigie/prisma-client-py#714), so an earlier iteration of this PR treated `PUT {"metadata": null}` as a no-op. That doesn't match the natural caller expectation that explicit-null clears the field. Encode it as the JSON literal `null` instead — stored as Postgres `jsonb 'null'`, which prisma deserializes back to Python `None` on read. Subsequent reads return `metadata: null`, so the field is effectively cleared from the caller's perspective. Strict SQL NULL remains unreachable via the typed client and would require raw SQL. Also clean up stale `jsonify_object` references in test mock comments (replaced by `_serialize_metadata_for_prisma`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(memory ui): use shared DeleteResourceModal for memory deletion Swap the imperative `Modal.confirm` in MemoryView for the shared `DeleteResourceModal`, so memory deletion matches the rest of the dashboard: type-to-confirm guard on the key, in-flight loading state on the OK button, cancel disabled while the request is pending, and the modal stays open on error so the user can retry. Made-with: Cursor --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>