mirror of
https://github.com/tiennm99/litellm.git
synced 2026-07-11 01:05:19 +00:00
82a9b0ea03
* feat(ui): add Chat UI v0 — standalone LiteLLM-branded chat window Adds a full chat UI accessible from the sidebar Chat link (opens in new tab). - Standalone route at /chat (outside dashboard layout — no Navbar/Sidebar chrome) - Claude.ai-style layout: model selector top-left, LiteLLM logo center, settings top-right - Greeting with time-of-day, centered input card, suggestion chips (Write/Learn/Code/Brainstorm) - Sliding conversation history sidebar with Cmd+K search, rename, delete, date grouping - localStorage-backed conversation persistence (litellm_chat_history_v1) - Streaming completions via makeOpenAIChatCompletionRequest with AbortController stop support - MCP server picker (toggle servers on/off per conversation) - LiteLLM aesthetic: white/light-gray background, Ant Design blue (#1677ff) primary, system font - Sidebar2: Chat menu item opens in new tab via window.open * feat(chat-ui): responses API + MCP tool execution display - Switch /chat from chat completions to responses API (previous_response_id session chaining) - Add MCP server picker with search filter in chat input bar - Show MCP tool call events (list_tools + call_tool) inline in chat via MCPEventsDisplay - Add tool chip strip showing available tools when MCP servers are selected - Non-blocking MCP toggle: server added immediately, verification in background (works for no-auth MCPs like deepwiki) - Add truncateAfterMessage to useChatHistory for edit/retry - Sync activeConversationId on URL change (fixes stale conversation on new chat) - Add "Open Chat" shortcut button to sidebar * fix(chat-ui): switch to responses API, remove dead code, add tests - Switch handleSend from makeOpenAIChatCompletionRequest to makeOpenAIResponsesRequest with previous_response_id session chaining - Add responsesSessionId state; reset to null when starting a new conversation - Remove unused ChatInputBar.tsx and ModelSelector.tsx (dead code) - Add tests/test_litellm/test_chat_ui_responses_session.py covering previous_response_id forwarding and signature validation * fix(chat-ui): address greptile review issues - Reset responsesSessionId when activeConversationId changes (not just on new conversation) - Wire onMCPEvent callback into makeOpenAIResponsesRequest; render MCPEventsDisplay below messages - Clear mcpEvents on each new send - Explicitly filter history to user/assistant roles only (no tool-role casting) - Remove duplicate "Chat" menu item from sidebar (pinned button serves same purpose) - Make Sider a flex column so "Open Chat" button actually pins to bottom - Fix tests to intercept real HTTP requests and assert previous_response_id in body * fix(chat-ui): address greptile review feedback (greploop iteration 1) - Fix duplicate context: when responsesSessionId is set, only send the new user message as input (prior context is already server-side via session chaining). Full history is still sent on the first turn. - Fix ephemeral MCP events: store events per-message in ChatMessage.mcpEvents instead of ephemeral component state. Events now survive across turns and render inline below each assistant response via MCPEventsDisplay. - Remove stale mcpEvents useState and ephemeral panel at bottom of chat. * fix(chat-ui): address greptile review feedback (greploop iteration 2) - Fix stale session on edit/retry: derive previousResponseId as null when historyOverride is set so edit/retry always starts a fresh Responses API session rather than chaining off a now-invalid prior session - Fix unsafe MCPEvent cast: import MCPEvent directly from MCPEventsDisplay into types.ts and type ChatMessage.mcpEvents as MCPEvent[], eliminating the bare 'as MCPEvent[]' cast in ChatMessages.tsx * fix(chat-ui): fix MCPEvent layering, batch localStorage writes, module-level test imports - Move MCPEvent interface definition into chat/types.ts (single source of truth) - MCPEventsDisplay.tsx now imports MCPEvent from types.ts instead of defining it locally - Batch MCP event localStorage writes: accumulate during stream, persist once in finally - Move test imports to module level per PEP 8 convention * fix(chat-ui): fix MCPEvent import path and rename truncateFromMessage - responses_api.tsx now imports MCPEvent directly from chat/types (not via MCPEventsDisplay re-export) - Remove the now-unnecessary MCPEvent re-export from MCPEventsDisplay.tsx - Rename truncateAfterMessage → truncateFromMessage: the function removes the target message and all subsequent ones (not just what comes after), so the new name accurately describes the behavior * fix(responses-api): fix whitespace token filter and MCP server URL construction - Drop the delta.trim() whitespace filter that was silently swallowing spaces and newlines during streaming, causing words to concatenate and paragraphs to collapse. Only skip truly empty strings (delta.length > 0). - Use proxyBaseUrl for MCP server_url construction instead of the hardcoded relative path "litellm_proxy/mcp", so non-root deployments route correctly. * fix(responses-api): use unique server_label per MCP server to prevent tool routing collisions * fix(chat-ui): move MCPEvent to shared mcp_tools/types, skip partial events on abort - Move MCPEvent interface to mcp_tools/types.tsx (shared with MCPServer/MCPTool), eliminating the playground→chat cross-module dependency. chat/types.ts and both playground components now import from mcp_tools/types. - Only persist accumulated MCP events when the stream completes cleanly; aborted or errored turns drop partial events to avoid showing incomplete tool calls. * fix(responses-api): use server_name for MCP URL routing, fix test path - Use server_name (not alias) as the URL path segment for MCP server_url; alias is a display name that may differ from the registered proxy route. URL-encode the path to handle names with spaces/special characters. - Fix sys.path.insert in tests to use __file__-relative path so tests pass regardless of which directory pytest is invoked from. * fix(chat-ui): fix stale session after failed edit, clean MCP event persistence, unique server_label - Eagerly call setResponsesSessionId(null) when historyOverride is set so a failed/aborted edit does not leave a stale session contaminating the next turn - Replace abort-signal check with streamCompletedCleanly flag to correctly skip MCP event persistence on both abort and non-abort errors (network/API failures) - Use server_name (unique) as server_label instead of alias to prevent silent tool-routing failures when two MCP servers share the same display name
128 lines
4.7 KiB
Python
128 lines
4.7 KiB
Python
"""
|
|
Tests for responses API session chaining used by the chat UI.
|
|
|
|
Verifies that:
|
|
1. previous_response_id is correctly forwarded when provided
|
|
2. Absence of previous_response_id does not break the call
|
|
3. The aresponses function signature exposes the expected parameters
|
|
"""
|
|
import inspect
|
|
import json
|
|
import os
|
|
import sys
|
|
import unittest.mock as mock
|
|
|
|
# Use __file__ so the import path is correct regardless of the pytest working directory.
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", ".."))
|
|
|
|
import httpx
|
|
import pytest
|
|
|
|
import litellm
|
|
|
|
|
|
class TestResponsesSessionChaining:
|
|
"""Test previous_response_id session chaining for the chat UI."""
|
|
|
|
def test_responses_api_signature_accepts_previous_response_id(self):
|
|
"""aresponses must accept previous_response_id and onResponseId-like params."""
|
|
sig = inspect.signature(litellm.aresponses)
|
|
assert "previous_response_id" in sig.parameters, (
|
|
"aresponses must accept previous_response_id for multi-turn session chaining"
|
|
)
|
|
assert "input" in sig.parameters, "aresponses must accept input"
|
|
assert "model" in sig.parameters, "aresponses must accept model"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_previous_response_id_included_in_request_body(self):
|
|
"""previous_response_id must appear in the outgoing HTTP request body."""
|
|
captured_body: dict = {}
|
|
|
|
async def mock_send(self_transport, request: httpx.Request, **kwargs):
|
|
try:
|
|
captured_body.update(json.loads(request.content))
|
|
except Exception:
|
|
pass
|
|
# Return a minimal valid responses API response
|
|
response_json = {
|
|
"id": "resp_test123",
|
|
"object": "response",
|
|
"model": "gpt-4o-mini",
|
|
"output": [
|
|
{
|
|
"type": "message",
|
|
"id": "msg_001",
|
|
"role": "assistant",
|
|
"content": [{"type": "output_text", "text": "hi", "annotations": []}],
|
|
"status": "completed",
|
|
}
|
|
],
|
|
"usage": {"input_tokens": 5, "output_tokens": 3, "total_tokens": 8},
|
|
"status": "completed",
|
|
"created_at": 1700000000,
|
|
}
|
|
return httpx.Response(
|
|
200,
|
|
json=response_json,
|
|
request=request,
|
|
)
|
|
|
|
with mock.patch("httpx.AsyncClient.send", mock_send):
|
|
try:
|
|
await litellm.aresponses(
|
|
input="hello",
|
|
model="gpt-4o-mini",
|
|
previous_response_id="resp_prev_abc",
|
|
api_key="sk-test-fake",
|
|
)
|
|
except Exception:
|
|
pass # response parsing may fail; we only care about the outgoing body
|
|
|
|
assert captured_body.get("previous_response_id") == "resp_prev_abc", (
|
|
f"Expected previous_response_id in request body, got: {captured_body}"
|
|
)
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_no_previous_response_id_omitted_from_request(self):
|
|
"""When previous_response_id is None, it must not appear in the request body."""
|
|
captured_body: dict = {}
|
|
|
|
async def mock_send(self_transport, request: httpx.Request, **kwargs):
|
|
try:
|
|
captured_body.update(json.loads(request.content))
|
|
except Exception:
|
|
pass
|
|
response_json = {
|
|
"id": "resp_new001",
|
|
"object": "response",
|
|
"model": "gpt-4o-mini",
|
|
"output": [
|
|
{
|
|
"type": "message",
|
|
"id": "msg_001",
|
|
"role": "assistant",
|
|
"content": [{"type": "output_text", "text": "hi", "annotations": []}],
|
|
"status": "completed",
|
|
}
|
|
],
|
|
"usage": {"input_tokens": 5, "output_tokens": 3, "total_tokens": 8},
|
|
"status": "completed",
|
|
"created_at": 1700000000,
|
|
}
|
|
return httpx.Response(200, json=response_json, request=request)
|
|
|
|
with mock.patch("httpx.AsyncClient.send", mock_send):
|
|
try:
|
|
await litellm.aresponses(
|
|
input="hello",
|
|
model="gpt-4o-mini",
|
|
previous_response_id=None,
|
|
api_key="sk-test-fake",
|
|
)
|
|
except Exception:
|
|
pass
|
|
|
|
assert "previous_response_id" not in captured_body, (
|
|
"previous_response_id must be omitted from the request body when None"
|
|
)
|