From af16ba23cd46fa3d3b096daa8d725df2b4d78976 Mon Sep 17 00:00:00 2001 From: ttzn Date: Wed, 24 Mar 2021 23:52:08 +0100 Subject: [PATCH] @StandardException feature working draft * move feature under experimental * replace ProviderFor with Provides * add doc material (to be completed) * add author --- AUTHORS | 1 + .../handlers/HandleStandardException.java | 8 ++--- .../{ => experimental}/StandardException.java | 2 +- .../handlers/HandleStandardException.java | 9 +++-- .../resource/before/StandardExceptions.java | 6 ++-- .../experimental/StandardException.html | 36 +++++++++++++++++++ .../features/experimental/index.html | 4 +++ .../StandardExceptionExample_post.jpage | 16 +++++++++ .../StandardExceptionExample_pre.jpage | 5 +++ 9 files changed, 74 insertions(+), 13 deletions(-) rename src/core/lombok/{ => experimental}/StandardException.java (97%) create mode 100644 website/templates/features/experimental/StandardException.html create mode 100644 website/usageExamples/StandardExceptionExample_post.jpage create mode 100644 website/usageExamples/StandardExceptionExample_pre.jpage diff --git a/AUTHORS b/AUTHORS index f152f0c7..547246d9 100755 --- a/AUTHORS +++ b/AUTHORS @@ -2,6 +2,7 @@ Lombok contributors in alphabetical order: Adam Juraszek Aleksandr Zhelezniak +Amine Touzani Andre Brait Bulgakov Alexander Caleb Brinkman diff --git a/src/core/lombok/eclipse/handlers/HandleStandardException.java b/src/core/lombok/eclipse/handlers/HandleStandardException.java index 9996f4fa..e7f25edb 100755 --- a/src/core/lombok/eclipse/handlers/HandleStandardException.java +++ b/src/core/lombok/eclipse/handlers/HandleStandardException.java @@ -23,16 +23,16 @@ package lombok.eclipse.handlers; import lombok.AccessLevel; import lombok.ConfigurationKeys; -import lombok.StandardException; +import lombok.experimental.StandardException; import lombok.core.AST.Kind; import lombok.core.AnnotationValues; import lombok.eclipse.Eclipse; import lombok.eclipse.EclipseAnnotationHandler; import lombok.eclipse.EclipseNode; import lombok.eclipse.handlers.EclipseHandlerUtil.*; +import lombok.spi.Provides; import org.eclipse.jdt.internal.compiler.ast.*; import org.eclipse.jdt.internal.compiler.classfmt.ClassFileConstants; -import org.mangosdk.spi.ProviderFor; import java.lang.reflect.Modifier; import java.util.*; @@ -42,7 +42,7 @@ import static lombok.eclipse.Eclipse.ECLIPSE_DO_NOT_TOUCH_FLAG; import static lombok.eclipse.Eclipse.pos; import static lombok.eclipse.handlers.EclipseHandlerUtil.*; -@ProviderFor(EclipseAnnotationHandler.class) +@Provides public class HandleStandardException extends EclipseAnnotationHandler { private static final String NAME = StandardException.class.getSimpleName(); @@ -175,12 +175,10 @@ public class HandleStandardException extends EclipseAnnotationHandler parameters, EclipseNode sourceNode) { - ASTNode source = sourceNode.get(); TypeDeclaration typeDeclaration = ((TypeDeclaration) type.get()); boolean isEnum = (((TypeDeclaration) type.get()).modifiers & ClassFileConstants.AccEnum) != 0; - if (isEnum) level = AccessLevel.PRIVATE; boolean addConstructorProperties; diff --git a/src/core/lombok/StandardException.java b/src/core/lombok/experimental/StandardException.java similarity index 97% rename from src/core/lombok/StandardException.java rename to src/core/lombok/experimental/StandardException.java index 0456a649..9f8a4e65 100644 --- a/src/core/lombok/StandardException.java +++ b/src/core/lombok/experimental/StandardException.java @@ -19,7 +19,7 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ -package lombok; +package lombok.experimental; import java.lang.annotation.ElementType; import java.lang.annotation.Retention; diff --git a/src/core/lombok/javac/handlers/HandleStandardException.java b/src/core/lombok/javac/handlers/HandleStandardException.java index 6a382788..598f1aa7 100644 --- a/src/core/lombok/javac/handlers/HandleStandardException.java +++ b/src/core/lombok/javac/handlers/HandleStandardException.java @@ -30,7 +30,7 @@ import com.sun.tools.javac.util.ListBuffer; import com.sun.tools.javac.util.Name; import lombok.AccessLevel; import lombok.ConfigurationKeys; -import lombok.StandardException; +import lombok.experimental.StandardException; import lombok.core.AST.Kind; import lombok.core.AnnotationValues; import lombok.delombok.LombokOptionsFactory; @@ -39,13 +39,13 @@ import lombok.javac.JavacAnnotationHandler; import lombok.javac.JavacNode; import lombok.javac.JavacTreeMaker; import lombok.javac.handlers.JavacHandlerUtil.*; -import org.mangosdk.spi.ProviderFor; +import lombok.spi.Provides; import static lombok.core.handlers.HandlerUtil.handleFlagUsage; import static lombok.javac.Javac.CTC_VOID; import static lombok.javac.handlers.JavacHandlerUtil.*; -@ProviderFor(JavacAnnotationHandler.class) +@Provides public class HandleStandardException extends JavacAnnotationHandler { private static final String NAME = StandardException.class.getSimpleName(); @@ -161,7 +161,6 @@ public class HandleStandardException extends JavacAnnotationHandler"), null, List.nil(), params.toList(), List.nil(), - maker.Block(0L, statements.toList()), null), source.get(), typeNode.getContext()); + maker.Block(0L, statements.toList()), null), source); } public static boolean isLocalType(JavacNode type) { diff --git a/test/transform/resource/before/StandardExceptions.java b/test/transform/resource/before/StandardExceptions.java index 7e4a3b93..939e1b6b 100644 --- a/test/transform/resource/before/StandardExceptions.java +++ b/test/transform/resource/before/StandardExceptions.java @@ -1,6 +1,8 @@ -@lombok.StandardException class EmptyException extends Exception { +import lombok.experimental.StandardException; + +@StandardException class EmptyException extends Exception { } -@lombok.StandardException class NoArgsException extends Exception { +@StandardException class NoArgsException extends Exception { public NoArgsException() { } } diff --git a/website/templates/features/experimental/StandardException.html b/website/templates/features/experimental/StandardException.html new file mode 100644 index 00000000..25324c4b --- /dev/null +++ b/website/templates/features/experimental/StandardException.html @@ -0,0 +1,36 @@ +<#import "../_features.html" as f> + +<@f.scaffold title="@StandardException" + logline="TODO"> + <@f.history> +

+ @StandardException was introduced as an experimental feature in lombok v1.18.21. +

+ + + <@f.overview> +

+ This annotation is intended to be used on subclasses of java.util.Throwable. For each of the four constructors in Throwable, it will generate a corresponding constructor in the target class, that simply forwards its argument to its super-counterpart. +

+ If any of those constructors is manually overriden, it is simply skipped. This allows applying special treatment such as annotations. +

+ + + <@f.snippets name="StandardException" /> + + <@f.confKeys> +
+ lombok.standardException.addConstructorProperties = [true | false] (default: false) +
+ lombok.standardException.flagUsage = [warning | error] (default: not set) +
+ Lombok will flag any usage of @StandardException as a warning or error if configured. +
+ + + <@f.smallPrint> +

+ Although such situation is unlikely to occur, this annotation can technically be applied to any class for which all four expected constructors are defined in a superclass. +

+ + diff --git a/website/templates/features/experimental/index.html b/website/templates/features/experimental/index.html index 32590815..34dd3bb4 100644 --- a/website/templates/features/experimental/index.html +++ b/website/templates/features/experimental/index.html @@ -75,6 +75,10 @@ <@main.feature title="@Jacksonized" href="Jacksonized"> Bob, meet Jackson. Lets make sure you become fast friends. + + <@main.feature title="@StandardException" href="StandardException"> + TODO + <@f.confKeys> diff --git a/website/usageExamples/StandardExceptionExample_post.jpage b/website/usageExamples/StandardExceptionExample_post.jpage new file mode 100644 index 00000000..148603a9 --- /dev/null +++ b/website/usageExamples/StandardExceptionExample_post.jpage @@ -0,0 +1,16 @@ +public class ExampleException extends Exception { + public ExampleException() { + } + + public ExampleException(String message) { + super(message); + } + + public ExampleException(Throwable cause) { + super(cause); + } + + public ExampleException(String message, Throwable cause) { + super(message, cause); + } +} \ No newline at end of file diff --git a/website/usageExamples/StandardExceptionExample_pre.jpage b/website/usageExamples/StandardExceptionExample_pre.jpage new file mode 100644 index 00000000..8d85286c --- /dev/null +++ b/website/usageExamples/StandardExceptionExample_pre.jpage @@ -0,0 +1,5 @@ +import lombok.experimental.StandardException; + +@StandardException +public class ExampleException extends Exception { +} \ No newline at end of file