tiennm99/loto
1
0
Fork 0
mirror of https://github.com/tiennm99/loto.git synced 2026-09-03 06:19:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: move shared modules out of app/

Browse Source 
`app/` should hold route segments only. Game logic and the player-card
component are imported by both routes, so they belong outside:

  app/loto-game-logic.ts   -> lib/game-logic.ts
  app/loto-player-board.tsx -> components/player-board.tsx

Imports use the existing @/* alias. Drops the redundant `loto-` prefix.
Also fixes the package name from the scaffold default.
This commit is contained in:
tiennm99
2026-04-26 19:34:37 +07:00
parent dd64aa6ed3
commit 254a6dc39a
8 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/docs/code-standards.md
+5 -5
View File
@@ -2,7 +2,7 @@
## File Naming & Structure
- **Kebab-case** for all files: `loto-player-board.tsx`, `loto-game-logic.ts`.
- **Kebab-case** for all files: `player-board.tsx`, `game-logic.ts`.
- **Descriptive names**: Long names are preferred for self-documentation. Avoid ambiguity.
- **Single responsibility**: Each file has one primary export (component or utilities).
- **Max 200 lines per file**: Split larger components into smaller focused ones.
@@ -81,13 +81,13 @@ function loadGrid(prefix = "loto"): number[][] | null {
| camelCase | `handleCellClick`, `storagePrefix` | variables, functions, props |
| PascalCase | `PlayerBoard`, `MasterPage` | components, types |
| UPPER_SNAKE | `STORAGE_KEY`, `NUM_ROWS` | constants |
| kebab-case | `loto-player-board.tsx` | file names |
| kebab-case | `player-board.tsx` | file names |
## Comment Style
- Document **why**, not **what**. The code shows what it does.
- Use `/** JSDoc */` for exported functions.
- Inline comments for complex logic (e.g., weighted random selection in `loto-game-logic.ts:19–28`).
- Inline comments for complex logic (e.g., weighted random selection in `lib/game-logic.ts:19–28`).
### Example
```typescript
@@ -111,8 +111,8 @@ function randomANumberInRow(weights: number[]): number {
```typescript
import { useCallback, useState } from "react";
import Link from "next/link";
import PlayerBoard from "./loto-player-board";
import { generateGrid } from "./loto-game-logic";
import PlayerBoard from "@/components/player-board";
import { generateGrid } from "@/lib/game-logic";
```
## Testing (Not Currently Implemented)