mirror of
https://github.com/tiennm99/miti99bot-js.git
synced 2026-05-14 21:52:53 +00:00
tiennm99
ea7df56e2d
The integration phase. Wires Phase 02 (MongoKVStore) and Phase 03
(MongoTradesStore + MongoSqlStore shim) into the request path behind
two env flags so KV and Atlas run side-by-side until cutover.
Storage routing
- DualKVStore + DualSqlStore: Promise.allSettled writes to BOTH backends,
reads from primary only. Secondary failures log + enqueue onto a KV
retry queue (__retry:mongo-failed:* / __retry:mongo-sql-failed:*).
Primary failure throws. _kind="dual" sentinel for test seam.
- create-store.js + create-sql-store.js: full flag matrix (STORAGE_PRIMARY
∈ {kv,mongo}, DUAL_WRITE ∈ {0,1}, MONGODB_URI presence) with
STUB_SENTINEL short-circuit for deploy-time. Post-cutover shape commented
inline so Phase 07 simplification is mechanical.
Stub mongo for register
- scripts/stub-kv.js: STUB_SENTINEL constant + duck-typed stubMongo
(no-op connect/close, throwing collection access). Replaces the
originally-planned string sentinel which would have stalled register.js
on serverSelectionTimeoutMS if ever passed to MongoClient (code-reviewer #2).
- scripts/register.js: stub env passes MONGODB_URI=STUB_SENTINEL,
STORAGE_PRIMARY="kv", DUAL_WRITE="0". Asserted via vi.spyOn that
MongoClient.prototype.connect is never reached.
Drift verifier cron (1/hr)
- src/cron/drift-verifier.js: drains both retry queues by re-attempting
secondary writes, deletes on success. Spot-checks parity by sampling
DRIFT_SAMPLE_N keys per module, hashing, logging mismatches.
- src/modules/cron-dispatcher.js: SYSTEM_CRONS array dispatched alongside
module crons. Keeping system cron out of registry.crons preserves
existing module-cron length tests and is the cleaner design.
- wrangler.toml: vars STORAGE_PRIMARY/DUAL_WRITE/DRIFT_SAMPLE_N + cron
schedule "0 * * * *" added.
Trading wiring
- src/modules/registry.js: builds new MongoTradesStore(env) when Mongo
is in play and threads it as tradesStore into trading module's init
context. Trading module already accepted optional tradesStore (Phase 03
backwards-compat) — D1 path remains for STORAGE_PRIMARY=kv + DUAL_WRITE=0.
Tests + verification
- tests/db/dual-kv-store.test.js, dual-sql-store.test.js: write-both,
secondary-fail-logs+enqueues, primary-fail-throws, reads-primary-only,
_kind sentinel.
- tests/db/stub-mongo-sentinel.test.js: spy on MongoClient.connect,
assert zero calls across all flag-matrix combos.
- tests/cron/drift-verifier.test.js: queue drain, skip paths, error safety.
- tests/e2e/storage-roundtrip.test.js: wordle KV dual-write +
trading MongoTradesStore against fake-mongo.
Tests: 577 → 638 (+61). register:dry passes without Atlas. Lint clean.
Concerns
- Drift-verifier parity-spot-check tests assert queue-drain only;
full mismatch detection needs real Atlas (Vitest ES-module caching
blocks reliable prototype patching). Verifier logic verified by
inspection.