mirror of
https://github.com/tiennm99/miti99bot.git
synced 2026-06-09 00:17:55 +00:00
tiennm99
f3b9891a54
Rename: - Go module github.com/tiennm99/miti99bot-go → github.com/tiennm99/miti99bot - CloudFormation stack miti99bot-aws-port → miti99bot - Drop "port", "Cloud Run", "GCP", "cutover", "Phase NN" framing from active code and docs — project reads as canonical AWS-Lambda from now on. AWS deploy guide + flow fix: - New docs/deploy-aws-free-tier-guide.md — Ubuntu 24.04 ARM64 onboarding with project-local venv (pip awscli + sam-cli), SSM secrets via read -s, idempotent OIDC provider + role creation, $1 budget alarm. - Drop sam build from the pipeline — provided.al2023 + makefile builder expects a Makefile in CodeUri (build/lambda/, the output dir), so the step always fails. sam deploy --template-file template.yaml now reads the raw template and zips build/lambda/ directly. - Rollback section rewritten — use continue-update-rollback / cancel-update-stack / git-SHA redeploy. Drop the broken --use-previous-template recipe. - DynamoDB free-tier row corrected (on-demand is 2.5M read / 1M write request units, not 25 RCU/WCU). Updated: - README.md fully rewritten (drops port/legacy framing, lists modules, points new users at the free-tier guide). - aws/README.md retitled "AWS account setup", phase numbers stripped. - Makefile / .github/workflows/deploy.yml — sam deploy flow. - samconfig.toml — stack_name = "miti99bot". - Go comments — Cloud Run → Lambda, Cloud Scheduler → EventBridge Scheduler, Cloud Logging → CloudWatch Logs. - Struct field GCPProject → FirestoreProject (env GOOGLE_CLOUD_PROJECT unchanged). Plus advisory reports under plans/reports/ from the code-reviewer + researcher passes that informed the fixes. Verified: go vet ./..., go build ./..., go test ./... all green.
104 lines
2.9 KiB
Go
104 lines
2.9 KiB
Go
package server
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"log/slog"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
logger "github.com/tiennm99/miti99bot/internal/log"
|
|
)
|
|
|
|
// captureLogger swaps the package-level logger for one writing to buf and
|
|
// returns a restore func. Tests must defer the restore.
|
|
func captureLogger(t *testing.T) (*bytes.Buffer, func()) {
|
|
t.Helper()
|
|
prev := logger.Default()
|
|
buf := &bytes.Buffer{}
|
|
logger.SetDefault(slog.New(slog.NewJSONHandler(buf, &slog.HandlerOptions{Level: slog.LevelInfo})))
|
|
return buf, func() { logger.SetDefault(prev) }
|
|
}
|
|
|
|
func decodeReqLine(t *testing.T, buf *bytes.Buffer) map[string]any {
|
|
t.Helper()
|
|
lines := strings.Split(strings.TrimRight(buf.String(), "\n"), "\n")
|
|
for _, line := range lines {
|
|
var rec map[string]any
|
|
if err := json.Unmarshal([]byte(line), &rec); err != nil {
|
|
continue
|
|
}
|
|
if rec["msg"] == "req" {
|
|
return rec
|
|
}
|
|
}
|
|
t.Fatalf("no req line found in:\n%s", buf.String())
|
|
return nil
|
|
}
|
|
|
|
func TestLogRequests_LogsMethodPathStatus(t *testing.T) {
|
|
buf, restore := captureLogger(t)
|
|
defer restore()
|
|
|
|
inner := http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
|
w.WriteHeader(http.StatusCreated)
|
|
})
|
|
rec := httptest.NewRecorder()
|
|
LogRequests(inner).ServeHTTP(rec, httptest.NewRequest(http.MethodPost, "/webhook", nil))
|
|
|
|
got := decodeReqLine(t, buf)
|
|
if got["method"] != "POST" {
|
|
t.Errorf("method = %v, want POST", got["method"])
|
|
}
|
|
if got["path"] != "/webhook" {
|
|
t.Errorf("path = %v, want /webhook", got["path"])
|
|
}
|
|
if got["status"].(float64) != float64(http.StatusCreated) {
|
|
t.Errorf("status = %v, want 201", got["status"])
|
|
}
|
|
if _, ok := got["ms"]; !ok {
|
|
t.Errorf("missing ms field")
|
|
}
|
|
}
|
|
|
|
func TestLogRequests_DefaultStatus200WhenNotSet(t *testing.T) {
|
|
buf, restore := captureLogger(t)
|
|
defer restore()
|
|
|
|
// Inner handler writes a body but never calls WriteHeader explicitly.
|
|
inner := http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
|
_, _ = w.Write([]byte("ok"))
|
|
})
|
|
rec := httptest.NewRecorder()
|
|
LogRequests(inner).ServeHTTP(rec, httptest.NewRequest(http.MethodGet, "/", nil))
|
|
|
|
got := decodeReqLine(t, buf)
|
|
// Even though our recorder didn't see WriteHeader, our middleware
|
|
// should report 200 — Go's net/http implicitly writes 200 on first
|
|
// body write.
|
|
if got["status"].(float64) != float64(http.StatusOK) {
|
|
t.Errorf("status = %v, want 200 (implicit)", got["status"])
|
|
}
|
|
}
|
|
|
|
func TestLogRequests_PreservesInnerBehavior(t *testing.T) {
|
|
_, restore := captureLogger(t)
|
|
defer restore()
|
|
|
|
inner := http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
|
w.WriteHeader(http.StatusTeapot)
|
|
_, _ = w.Write([]byte("brewing"))
|
|
})
|
|
rec := httptest.NewRecorder()
|
|
LogRequests(inner).ServeHTTP(rec, httptest.NewRequest(http.MethodGet, "/", nil))
|
|
|
|
if rec.Code != http.StatusTeapot {
|
|
t.Errorf("status code = %d, want 418", rec.Code)
|
|
}
|
|
if rec.Body.String() != "brewing" {
|
|
t.Errorf("body = %q, want 'brewing'", rec.Body.String())
|
|
}
|
|
}
|