mirror of
https://github.com/tiennm99/miti99bot.git
synced 2026-09-20 04:23:43 +00:00
tiennm99
1e7b1a9bca
Phase 5 of the 2026-05-09 review remediation plan. Closes the handler-layer test gap (5 modules at 0% coverage in the audit) and ends the storage-package's CI t.Skip on Firestore emulator tests. - internal/testutil: Update fixture builders (NewPrivateMessage, NewGroupMessage, NewSupergroupMessage, NewChannelMessage) plus a RecordingBot that wraps the real go-telegram/bot.Bot with an httptest server. The bot library hits the test server instead of Telegram; multipart form fields are captured per call. Tests assert on Sent() / LastSent() / AssertSentText(). - Handler tests added: misc (4), util (7), wordle (10), loldle (9), loldleemoji (8). Cover happy paths, error paths, auth gates, group-vs-private subject keying, KV side effects. - Coverage 44.7% -> 69.8% (verified via -coverprofile). All packages now report coverage in CI output. - CI: ci.yml installs cloud-firestore-emulator beta component and starts it on localhost:8090 before go test. Sets FIRESTORE_EMULATOR_HOST + GOOGLE_CLOUD_PROJECT env so the storage package's emulator-gated tests execute instead of skipping. go test -race -count=1 ./... clean across all 15 packages locally.
120 lines
3.5 KiB
Go
120 lines
3.5 KiB
Go
package util_test
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/go-telegram/bot/models"
|
|
|
|
"github.com/tiennm99/miti99bot-go/internal/modules"
|
|
"github.com/tiennm99/miti99bot-go/internal/modules/util"
|
|
"github.com/tiennm99/miti99bot-go/internal/storage"
|
|
"github.com/tiennm99/miti99bot-go/internal/testutil"
|
|
)
|
|
|
|
// installUtil builds a registry with the util module + auth that admits the
|
|
// supplied owner so /stickerid (private) dispatches.
|
|
func installUtil(t *testing.T, ownerID int64) *testutil.RecordingBot {
|
|
t.Helper()
|
|
rb := testutil.NewRecordingBot(t)
|
|
reg, err := modules.Build([]string{"util"},
|
|
map[string]modules.Factory{"util": util.New},
|
|
storage.NewMemoryProvider(), nil)
|
|
if err != nil {
|
|
t.Fatalf("Build: %v", err)
|
|
}
|
|
modules.Install(rb.Bot, reg, modules.Auth{BotOwnerID: ownerID})
|
|
return rb
|
|
}
|
|
|
|
func TestInfo_PrivateChat(t *testing.T) {
|
|
rb := installUtil(t, 0)
|
|
rb.Bot.ProcessUpdate(context.Background(), testutil.NewPrivateMessage(42, "/info"))
|
|
|
|
got := rb.LastSent().Text()
|
|
for _, want := range []string{"chat id: 42", "thread id: n/a", "sender id: 42"} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("info reply missing %q; got %q", want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestInfo_GroupChat(t *testing.T) {
|
|
rb := installUtil(t, 0)
|
|
rb.Bot.ProcessUpdate(context.Background(), testutil.NewGroupMessage(-100, 7, "/info"))
|
|
|
|
got := rb.LastSent().Text()
|
|
for _, want := range []string{"chat id: -100", "sender id: 7"} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("info reply missing %q; got %q", want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestInfo_ChannelMessageNoFrom(t *testing.T) {
|
|
rb := installUtil(t, 0)
|
|
rb.Bot.ProcessUpdate(context.Background(), testutil.NewChannelMessage(-200, "/info"))
|
|
|
|
got := rb.LastSent().Text()
|
|
if !strings.Contains(got, "sender id: n/a") {
|
|
t.Errorf("info channel reply missing 'sender id: n/a'; got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestHelp_RendersHTML(t *testing.T) {
|
|
rb := installUtil(t, 0)
|
|
rb.Bot.ProcessUpdate(context.Background(), testutil.NewPrivateMessage(1, "/help"))
|
|
|
|
calls := rb.Sent()
|
|
if len(calls) == 0 {
|
|
t.Fatal("/help produced no reply")
|
|
}
|
|
got := calls[len(calls)-1]
|
|
if got.Form["parse_mode"] != string(models.ParseModeHTML) {
|
|
t.Errorf("/help parse_mode = %q, want HTML", got.Form["parse_mode"])
|
|
}
|
|
if !strings.Contains(got.Text(), "<b>util</b>") {
|
|
t.Errorf("/help body missing util section; got %q", got.Text())
|
|
}
|
|
}
|
|
|
|
func TestStickerID_NoReply_ShowsUsage(t *testing.T) {
|
|
rb := installUtil(t, 999)
|
|
rb.Bot.ProcessUpdate(context.Background(), testutil.NewPrivateMessage(999, "/stickerid"))
|
|
|
|
got := rb.LastSent().Text()
|
|
if !strings.Contains(got, "Reply to a sticker") {
|
|
t.Errorf("stickerid usage missing; got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestStickerID_WithStickerReply_EchoesFileID(t *testing.T) {
|
|
rb := installUtil(t, 999)
|
|
upd := testutil.NewPrivateMessage(999, "/stickerid")
|
|
upd.Message.ReplyToMessage = &models.Message{
|
|
Sticker: &models.Sticker{
|
|
FileID: "AAA-file-id",
|
|
FileUniqueID: "uniq",
|
|
SetName: "TestSet",
|
|
Emoji: "🎉",
|
|
},
|
|
}
|
|
rb.Bot.ProcessUpdate(context.Background(), upd)
|
|
|
|
got := rb.LastSent().Text()
|
|
for _, want := range []string{"AAA-file-id", "uniq", "TestSet", "🎉"} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("stickerid reply missing %q; got %q", want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestStickerID_DeniedToNonOwner(t *testing.T) {
|
|
rb := installUtil(t, 999)
|
|
rb.Bot.ProcessUpdate(context.Background(), testutil.NewPrivateMessage(7, "/stickerid"))
|
|
if calls := rb.Sent(); len(calls) != 0 {
|
|
t.Errorf("non-owner /stickerid replied: %+v", calls)
|
|
}
|
|
}
|