mirror of
https://github.com/tiennm99/miti99bot.git
synced 2026-06-09 12:14:52 +00:00
tiennm99
6368bc80ce
Phase 4 of the 2026-05-09 review remediation plan. - internal/log: thin facade over log/slog.NewJSONHandler writing to stdout. Cloud Run's Cloud Logging integration auto-parses level, time, msg fields. Honours LOG_LEVEL env (debug|info|warn|error). Re-exports Info/Warn/Error/Fatal/Debug/With ergonomics. - Migrated all 22 stdlib log call sites: cmd/server/main.go (17), internal/server/router.go (2), internal/modules/dispatcher.go (1), internal/telegram/webhook.go (1), internal/modules/misc/misc.go (1). Format-string args replaced with structured key/value attrs. - Closes log-injection class (J3 from security audit) — slog escapes newlines and quotes inside field values, so attacker-controlled strings cannot synthesise fake log records (test: TestNewlineEscaping_NoLogInjection). go test -race -count=1 ./... clean across all 13 packages. Zero stdlib log imports remain outside internal/log.
99 lines
3.0 KiB
Go
99 lines
3.0 KiB
Go
// Package misc is a small stub module that proves the framework end-to-end:
|
|
// /ping (public, exercises KV write), /mstats (protected, exercises KV read),
|
|
// /fortytwo (private easter egg).
|
|
package misc
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/go-telegram/bot"
|
|
"github.com/go-telegram/bot/models"
|
|
|
|
"github.com/tiennm99/miti99bot-go/internal/log"
|
|
"github.com/tiennm99/miti99bot-go/internal/modules"
|
|
"github.com/tiennm99/miti99bot-go/internal/modules/util/chathelper"
|
|
"github.com/tiennm99/miti99bot-go/internal/storage"
|
|
)
|
|
|
|
// lastPingKey is the per-module KV key /ping writes and /mstats reads.
|
|
const lastPingKey = "last_ping"
|
|
|
|
// lastPing mirrors the JS bot's wire format: { at: <ms-since-epoch number> }.
|
|
// Stored as int64 ms-epoch (not time.Time → RFC3339) so a future cross-runtime
|
|
// KV export/import migration round-trips byte-for-byte.
|
|
type lastPing struct {
|
|
At int64 `json:"at"`
|
|
}
|
|
|
|
// New is the module Factory. Captures the per-module Deps via closure so each
|
|
// command handler has direct access to its KV store.
|
|
func New(deps modules.Deps) modules.Module {
|
|
return modules.Module{
|
|
Commands: []modules.Command{
|
|
pingCommand(deps),
|
|
mstatsCommand(deps),
|
|
fortytwoCommand(),
|
|
},
|
|
}
|
|
}
|
|
|
|
func pingCommand(deps modules.Deps) modules.Command {
|
|
return modules.Command{
|
|
Name: "ping",
|
|
Visibility: modules.VisibilityPublic,
|
|
Description: "Health check — replies pong and records last ping",
|
|
Handler: func(ctx context.Context, b *bot.Bot, update *models.Update) error {
|
|
if update.Message == nil {
|
|
return nil
|
|
}
|
|
// Best-effort write — if KV is unavailable, still reply.
|
|
payload := lastPing{At: chathelper.NowMillis()}
|
|
if err := deps.KV.PutJSON(ctx, lastPingKey, payload); err != nil {
|
|
log.Error("kv put failed", "module", "misc", "command", "ping", "key", lastPingKey, "err", err)
|
|
}
|
|
return chathelper.Reply(ctx, b, update.Message.Chat.ID, "pong")
|
|
},
|
|
}
|
|
}
|
|
|
|
func mstatsCommand(deps modules.Deps) modules.Command {
|
|
return modules.Command{
|
|
Name: "mstats",
|
|
Visibility: modules.VisibilityProtected,
|
|
Description: "Show the timestamp of the last /ping",
|
|
Handler: func(ctx context.Context, b *bot.Bot, update *models.Update) error {
|
|
if update.Message == nil {
|
|
return nil
|
|
}
|
|
var last lastPing
|
|
text := "last ping: never"
|
|
err := deps.KV.GetJSON(ctx, lastPingKey, &last)
|
|
switch {
|
|
case err == nil && last.At > 0:
|
|
text = fmt.Sprintf("last ping: %s",
|
|
time.UnixMilli(last.At).UTC().Format(time.RFC3339))
|
|
case err != nil && !errors.Is(err, storage.ErrNotFound):
|
|
return fmt.Errorf("misc /mstats: %w", err)
|
|
}
|
|
return chathelper.Reply(ctx, b, update.Message.Chat.ID, text)
|
|
},
|
|
}
|
|
}
|
|
|
|
func fortytwoCommand() modules.Command {
|
|
return modules.Command{
|
|
Name: "fortytwo",
|
|
Visibility: modules.VisibilityPrivate,
|
|
Description: "Easter egg — the answer",
|
|
Handler: func(ctx context.Context, b *bot.Bot, update *models.Update) error {
|
|
if update.Message == nil {
|
|
return nil
|
|
}
|
|
return chathelper.Reply(ctx, b, update.Message.Chat.ID, "The answer.")
|
|
},
|
|
}
|
|
}
|