tiennm99/serena
1
0
Fork 0
mirror of https://github.com/tiennm99/serena.git synced 2026-07-29 04:20:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use selectionRange for referencing symbols in tests

Browse Source
This commit is contained in:
Michael Panchenko
2025-04-27 15:42:55 +02:00
parent e6f0ddacef
commit 6a46a3768d
4 changed files with 126 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/multilspy/python/test_python_basic.py
+53 -23
View File
@@ -23,13 +23,19 @@ class TestLanguageServerBasics:
# Get references to the User class in models.py
file_path = os.path.join("test_repo", "models.py")
# Line 31 contains the User class definition
references = language_server.request_references(file_path, 31, 6)
# User class should be referenced in multiple files
assert len(references) > 0
# At least two references should be found (one for the class definition itself)
assert len(references) > 1
# Use selectionRange only
symbols = language_server.request_document_symbols(file_path)
user_symbol = next((s for s in symbols[0] if s.get("name") == "User"), None)
if not user_symbol or "selectionRange" not in user_symbol:
raise AssertionError("User symbol or its selectionRange not found")
sel_start = user_symbol["selectionRange"]["start"]
sel_end = user_symbol["selectionRange"]["end"]
found = False
for col in range(sel_start["character"], sel_end["character"] + 1):
references = language_server.request_references(file_path, sel_start["line"], col)
if len(references) > 1:
found = True
assert found, "User class should be referenced in multiple files (using selectionRange if present)"
@pytest.mark.parametrize("language_server", [Language.PYTHON], indirect=True)
def test_request_references_item_class(self, language_server: SyncLanguageServer):
@@ -37,14 +43,20 @@ class TestLanguageServerBasics:
# Get references to the Item class in models.py
file_path = os.path.join("test_repo", "models.py")
# Line 56 contains the Item class definition
references = language_server.request_references(file_path, 56, 6)
# Item class should be referenced in multiple places
assert len(references) > 0
# At least one reference should be in services.py (ItemService class)
services_references = [ref for ref in references if "services.py" in ref["uri"]]
assert len(services_references) > 0
# Use selectionRange only
symbols = language_server.request_document_symbols(file_path)
item_symbol = next((s for s in symbols[0] if s.get("name") == "Item"), None)
if not item_symbol or "selectionRange" not in item_symbol:
raise AssertionError("Item symbol or its selectionRange not found")
sel_start = item_symbol["selectionRange"]["start"]
sel_end = item_symbol["selectionRange"]["end"]
found = False
for col in range(sel_start["character"], sel_end["character"] + 1):
references = language_server.request_references(file_path, sel_start["line"], col)
services_references = [ref for ref in references if "services.py" in ref["uri"]]
if len(services_references) > 0:
found = True
assert found, "At least one reference should be in services.py (using selectionRange if present)"
@pytest.mark.parametrize("language_server", [Language.PYTHON], indirect=True)
def test_request_references_function_parameter(self, language_server: SyncLanguageServer):
@@ -52,20 +64,38 @@ class TestLanguageServerBasics:
# Get references to the id parameter in get_user method
file_path = os.path.join("test_repo", "services.py")
# Line 24 contains the get_user method with id parameter
references = language_server.request_references(file_path, 24, 16)
# id parameter should be referenced within the method
assert len(references) > 0
# Use selectionRange only
symbols = language_server.request_document_symbols(file_path)
get_user_symbol = next((s for s in symbols[0] if s.get("name") == "get_user"), None)
if not get_user_symbol or "selectionRange" not in get_user_symbol:
raise AssertionError("get_user symbol or its selectionRange not found")
sel_start = get_user_symbol["selectionRange"]["start"]
sel_end = get_user_symbol["selectionRange"]["end"]
found = False
for col in range(sel_start["character"], sel_end["character"] + 1):
references = language_server.request_references(file_path, sel_start["line"], col)
if len(references) > 0:
found = True
assert found, "id parameter should be referenced within the method (using selectionRange if present)"
@pytest.mark.parametrize("language_server", [Language.PYTHON], indirect=True)
def test_request_references_create_user_method(self, language_server: SyncLanguageServer):
# Get references to the create_user method in UserService
file_path = os.path.join("test_repo", "services.py")
# Line 15 contains the create_user method definition
references = language_server.request_references(file_path, 15, 9)
# Verify that we get valid references
assert len(references) > 1
# Use selectionRange only
symbols = language_server.request_document_symbols(file_path)
create_user_symbol = next((s for s in symbols[0] if s.get("name") == "create_user"), None)
if not create_user_symbol or "selectionRange" not in create_user_symbol:
raise AssertionError("create_user symbol or its selectionRange not found")
sel_start = create_user_symbol["selectionRange"]["start"]
sel_end = create_user_symbol["selectionRange"]["end"]
found = False
for col in range(sel_start["character"], sel_end["character"] + 1):
references = language_server.request_references(file_path, sel_start["line"], col)
if len(references) > 1:
found = True
assert found, "Should get valid references for create_user (using selectionRange if present)"
@pytest.mark.parametrize("language_server", [Language.PYTHON], indirect=True)
def test_retrieve_content_around_line(self, language_server: SyncLanguageServer):
test/multilspy/python/test_symbol_retrieval.py
+48 -30
View File
@@ -104,10 +104,18 @@ class TestLanguageServerSymbols:
# Test referencing symbols for create_user function
file_path = os.path.join("test_repo", "services.py")
# Line 15 contains the create_user function definition
ref_symbols = language_server.request_referencing_symbols(file_path, 15, 9)
# Verify we get referencing symbols
assert len(ref_symbols) > 0
symbols = language_server.request_document_symbols(file_path)
create_user_symbol = next((s for s in symbols[0] if s.get("name") == "create_user"), None)
if not create_user_symbol or "selectionRange" not in create_user_symbol:
raise AssertionError("create_user symbol or its selectionRange not found")
sel_start = create_user_symbol["selectionRange"]["start"]
sel_end = create_user_symbol["selectionRange"]["end"]
found = False
for col in range(sel_start["character"], sel_end["character"] + 1):
ref_symbols = language_server.request_referencing_symbols(file_path, sel_start["line"], col)
if len(ref_symbols) > 0:
found = True
assert found, "No referencing symbols found for create_user (selectionRange)"
# Verify the structure of referencing symbols
for symbol in ref_symbols:
@@ -123,19 +131,23 @@ class TestLanguageServerSymbols:
# Test referencing symbols for User class
file_path = os.path.join("test_repo", "models.py")
# Line 31 contains the User class definition
ref_symbols = language_server.request_referencing_symbols(file_path, 31, 6)
# Verify we get referencing symbols
assert len(ref_symbols) > 0
# At least one reference should be from services.py
services_references = [
symbol
for symbol in ref_symbols
if "location" in symbol and "uri" in symbol["location"] and "services.py" in symbol["location"]["uri"]
]
assert len(services_references) > 0
symbols = language_server.request_document_symbols(file_path)
user_symbol = next((s for s in symbols[0] if s.get("name") == "User"), None)
if not user_symbol or "selectionRange" not in user_symbol:
raise AssertionError("User symbol or its selectionRange not found")
sel_start = user_symbol["selectionRange"]["start"]
sel_end = user_symbol["selectionRange"]["end"]
found = False
for col in range(sel_start["character"], sel_end["character"] + 1):
ref_symbols = language_server.request_referencing_symbols(file_path, sel_start["line"], col)
services_references = [
symbol
for symbol in ref_symbols
if "location" in symbol and "uri" in symbol["location"] and "services.py" in symbol["location"]["uri"]
]
if len(services_references) > 0:
found = True
assert found, "No referencing symbols from services.py for User (selectionRange)"
@pytest.mark.parametrize("language_server", [Language.PYTHON], indirect=True)
def test_request_referencing_symbols_parameter(self, language_server: SyncLanguageServer):
@@ -143,19 +155,25 @@ class TestLanguageServerSymbols:
# Test referencing symbols for id parameter in get_user
file_path = os.path.join("test_repo", "services.py")
# Line 24 contains the get_user method with id parameter
ref_symbols = language_server.request_referencing_symbols(file_path, 24, 16)
# Verify we get referencing symbols
assert len(ref_symbols) > 0
# Verify the symbols include references within the method body
method_refs = [
symbol
for symbol in ref_symbols
if "location" in symbol and "range" in symbol["location"] and symbol["location"]["range"]["start"]["line"] > 24
]
assert len(method_refs) > 0
symbols = language_server.request_document_symbols(file_path)
get_user_symbol = next((s for s in symbols[0] if s.get("name") == "get_user"), None)
if not get_user_symbol or "selectionRange" not in get_user_symbol:
raise AssertionError("get_user symbol or its selectionRange not found")
sel_start = get_user_symbol["selectionRange"]["start"]
sel_end = get_user_symbol["selectionRange"]["end"]
found = False
for col in range(sel_start["character"], sel_end["character"] + 1):
ref_symbols = language_server.request_referencing_symbols(file_path, sel_start["line"], col)
method_refs = [
symbol
for symbol in ref_symbols
if "location" in symbol
and "range" in symbol["location"]
and symbol["location"]["range"]["start"]["line"] > sel_start["line"]
]
if len(method_refs) > 0:
found = True
assert found, "No referencing symbols within method body for get_user (selectionRange)"
@pytest.mark.parametrize("language_server", [Language.PYTHON], indirect=True)
def test_request_referencing_symbols_none(self, language_server: SyncLanguageServer):