Diagnostics, implementation and definition tools (WIP)

test/solidlsp/java/test_java_basic.py

@@ -5,7 +5,12 @@ import pytest
 from solidlsp import SolidLanguageServer
 from solidlsp.ls_config import Language
 from solidlsp.ls_utils import SymbolUtils
-from test.conftest import language_tests_enabled
+from test.conftest import (
+    find_identifier_position,
+    get_repo_path,
+    language_has_verified_implementation_support,
+    language_tests_enabled,
+)
 from test.solidlsp.conftest import format_symbol_for_assert, has_malformed_name, request_all_symbols
 
 pytestmark = [pytest.mark.java, pytest.mark.skipif(not language_tests_enabled(Language.JAVA), reason="Java tests disabled")]
@@ -52,6 +57,33 @@ class TestJavaLanguageServer:
         assert SymbolUtils.symbol_tree_contains_name(symbols, "Utils"), "Utils missing from overview"
         assert SymbolUtils.symbol_tree_contains_name(symbols, "Model"), "Model missing from overview"
 
+    if language_has_verified_implementation_support(Language.JAVA):
+
+        @pytest.mark.parametrize("language_server", [Language.JAVA], indirect=True)
+        def test_find_implementations(self, language_server: SolidLanguageServer) -> None:
+            repo_path = get_repo_path(Language.JAVA)
+            pos = find_identifier_position(repo_path / "src/main/java/test_repo/Greeter.java", "formatGreeting")
+            assert pos is not None, "Could not find Greeter.formatGreeting in fixture"
+
+            implementations = language_server.request_implementation("src/main/java/test_repo/Greeter.java", *pos)
+            assert implementations, "Expected at least one implementation of Greeter.formatGreeting"
+            assert any("ConsoleGreeter.java" in implementation.get("relativePath", "") for implementation in implementations), (
+                f"Expected ConsoleGreeter.formatGreeting in implementations, got: {implementations}"
+            )
+
+        @pytest.mark.parametrize("language_server", [Language.JAVA], indirect=True)
+        def test_request_implementing_symbols(self, language_server: SolidLanguageServer) -> None:
+            repo_path = get_repo_path(Language.JAVA)
+            pos = find_identifier_position(repo_path / "src/main/java/test_repo/Greeter.java", "formatGreeting")
+            assert pos is not None, "Could not find Greeter.formatGreeting in fixture"
+
+            implementing_symbols = language_server.request_implementing_symbols("src/main/java/test_repo/Greeter.java", *pos)
+            assert implementing_symbols, "Expected implementing symbols for Greeter.formatGreeting"
+            assert any(
+                symbol.get("name") == "formatGreeting" and "ConsoleGreeter.java" in symbol["location"].get("relativePath", "")
+                for symbol in implementing_symbols
+            ), f"Expected ConsoleGreeter.formatGreeting symbol, got: {implementing_symbols}"
+
     @pytest.mark.parametrize("language_server", [Language.JAVA], indirect=True)
     def test_bare_symbol_names(self, language_server) -> None:
         all_symbols = request_all_symbols(language_server)