mirror of
https://github.com/tiennm99/serena.git
synced 2026-10-04 22:13:47 +00:00
Michael Panchenko
d30cdf8474
Adds tests for name resolution for each language and fixes the name resolution where tests have failed. Also: Extends python tests to cover ty Extends skipping conditions for several LS (but only when not in CI) Better test output in CI Removed a wrong python test (started failing for ty and should have failed for pyright too)
67 lines
3.6 KiB
Python
67 lines
3.6 KiB
Python
import os
|
|
|
|
import pytest
|
|
|
|
from solidlsp import SolidLanguageServer
|
|
from solidlsp.ls_config import Language
|
|
from solidlsp.ls_utils import SymbolUtils
|
|
from test.conftest import language_tests_enabled
|
|
from test.solidlsp.conftest import format_symbol_for_assert, has_malformed_name, request_all_symbols
|
|
|
|
pytestmark = [pytest.mark.java, pytest.mark.skipif(not language_tests_enabled(Language.JAVA), reason="Java tests disabled")]
|
|
|
|
|
|
class TestJavaLanguageServer:
|
|
@pytest.mark.parametrize("language_server", [Language.JAVA], indirect=True)
|
|
def test_find_symbol(self, language_server: SolidLanguageServer) -> None:
|
|
symbols = language_server.request_full_symbol_tree()
|
|
assert SymbolUtils.symbol_tree_contains_name(symbols, "Main"), "Main class not found in symbol tree"
|
|
assert SymbolUtils.symbol_tree_contains_name(symbols, "Utils"), "Utils class not found in symbol tree"
|
|
assert SymbolUtils.symbol_tree_contains_name(symbols, "Model"), "Model class not found in symbol tree"
|
|
|
|
@pytest.mark.parametrize("language_server", [Language.JAVA], indirect=True)
|
|
def test_find_referencing_symbols(self, language_server: SolidLanguageServer) -> None:
|
|
# Use correct Maven/Java file paths
|
|
file_path = os.path.join("src", "main", "java", "test_repo", "Utils.java")
|
|
refs = language_server.request_references(file_path, 4, 20)
|
|
assert any("Main.java" in ref.get("relativePath", "") for ref in refs), "Main should reference Utils.printHello"
|
|
|
|
# Dynamically determine the correct line/column for the 'Model' class name
|
|
file_path = os.path.join("src", "main", "java", "test_repo", "Model.java")
|
|
symbols = language_server.request_document_symbols(file_path).get_all_symbols_and_roots()
|
|
model_symbol = None
|
|
for sym in symbols[0]:
|
|
if sym.get("name") == "Model" and sym.get("kind") == 5: # 5 = Class
|
|
model_symbol = sym
|
|
break
|
|
assert model_symbol is not None, "Could not find 'Model' class symbol in Model.java"
|
|
# Use selectionRange if present, otherwise fall back to range
|
|
if "selectionRange" in model_symbol:
|
|
sel_start = model_symbol["selectionRange"]["start"]
|
|
else:
|
|
sel_start = model_symbol["range"]["start"]
|
|
refs = language_server.request_references(file_path, sel_start["line"], sel_start["character"])
|
|
assert any("Main.java" in ref.get("relativePath", "") for ref in refs), (
|
|
"Main should reference Model (tried all positions in selectionRange)"
|
|
)
|
|
|
|
@pytest.mark.parametrize("language_server", [Language.JAVA], indirect=True)
|
|
def test_overview_methods(self, language_server: SolidLanguageServer) -> None:
|
|
symbols = language_server.request_full_symbol_tree()
|
|
assert SymbolUtils.symbol_tree_contains_name(symbols, "Main"), "Main missing from overview"
|
|
assert SymbolUtils.symbol_tree_contains_name(symbols, "Utils"), "Utils missing from overview"
|
|
assert SymbolUtils.symbol_tree_contains_name(symbols, "Model"), "Model missing from overview"
|
|
|
|
@pytest.mark.parametrize("language_server", [Language.JAVA], indirect=True)
|
|
def test_bare_symbol_names(self, language_server) -> None:
|
|
all_symbols = request_all_symbols(language_server)
|
|
malformed_symbols = []
|
|
for s in all_symbols:
|
|
if has_malformed_name(s):
|
|
malformed_symbols.append(s)
|
|
if malformed_symbols:
|
|
pytest.fail(
|
|
f"Found malformed symbols: {[format_symbol_for_assert(sym) for sym in malformed_symbols]}",
|
|
pytrace=False,
|
|
)
|