From 16c647d2a40721a994144c0766101f7b8c686ea7 Mon Sep 17 00:00:00 2001
From: meiwei <309921330@qq.com>
Date: Tue, 29 Aug 2023 11:22:23 +0800
Subject: [PATCH] perf[protocol] optimize protocol config

---
 .../com/zfoo/protocol/registration/ProtocolAnalysis.java  | 7 +------
 .../test/java/com/zfoo/protocol/util/DomUtilsTest.java    | 8 ++++----
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/protocol/src/main/java/com/zfoo/protocol/registration/ProtocolAnalysis.java b/protocol/src/main/java/com/zfoo/protocol/registration/ProtocolAnalysis.java
index d3b16a94..e50587f9 100644
--- a/protocol/src/main/java/com/zfoo/protocol/registration/ProtocolAnalysis.java
+++ b/protocol/src/main/java/com/zfoo/protocol/registration/ProtocolAnalysis.java
@@ -202,7 +202,7 @@ public class ProtocolAnalysis {
         var enhanceList = new ArrayList<IProtocolRegistration>();
         for (var moduleDefinition : xmlProtocols.getModules()) {
             var module = modules[moduleDefinition.getId()];
-            var packetClazzList = getModuleDefinitionClass(moduleDefinition);
+            var packetClazzList = moduleDefinitionClassMap.get(moduleDefinition.getId());;
             if (CollectionUtils.isEmpty(packetClazzList)) {
                 continue;
             }
@@ -221,11 +221,6 @@ public class ProtocolAnalysis {
         enhance(generateOperation, enhanceList);
     }
 
-    private static Set<Class<?>> getModuleDefinitionClass(XmlModuleDefinition moduleDefinition) {
-
-        return moduleDefinitionClassMap.get(moduleDefinition.getId());
-    }
-
     public static Set<Class<?>> scanPackageList(String packageName) {
         //获取该路径下所有类
         var clazzSet = new HashSet<String>();
diff --git a/protocol/src/test/java/com/zfoo/protocol/util/DomUtilsTest.java b/protocol/src/test/java/com/zfoo/protocol/util/DomUtilsTest.java
index 05b181ed..e8c208ec 100644
--- a/protocol/src/test/java/com/zfoo/protocol/util/DomUtilsTest.java
+++ b/protocol/src/test/java/com/zfoo/protocol/util/DomUtilsTest.java
@@ -22,23 +22,23 @@ public class DomUtilsTest {
     private static final String XML_WITH_HEAD = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\" ?>\n" +
             "\n" +
             "<protocols>\n" +
-            "    <module id=\"1\" name=\"common\" minId=\"1000\" maxId=\"2000\">\n" +
+            "    <module id=\"1\" name=\"common\">\n" +
             "        <protocol id=\"1000\" location=\"com.zfoo.test.CM_Int\"/>\n" +
             "        <protocol id=\"2000\" location=\"com.zfoo.test.SM_Int\"/>\n" +
             "    </module>\n" +
             "\n" +
-            "    <module id=\"2\" name=\"common\" minId=\"2000\" maxId=\"3000\">\n" +
+            "    <module id=\"2\" name=\"common\">\n" +
             "        <protocol id=\"3000\" location=\"com.zfoo.test.CM_Float\"/>\n" +
             "    </module>\n" +
             "</protocols>";
 
     private static final String XML_OF_STANDARD_TEXT = "<protocols>\n" +
-            "    <module id=\"1\" name=\"common\" minId=\"1000\" maxId=\"2000\">\n" +
+            "    <module id=\"1\" name=\"common\">\n" +
             "        <protocol id=\"1000\" location=\"com.zfoo.test.CM_Int\"/>\n" +
             "        <protocol id=\"2000\" location=\"com.zfoo.test.SM_Int\"/>\n" +
             "    </module>\n" +
             "\n" +
-            "    <module id=\"2\" name=\"common\" minId=\"2000\" maxId=\"3000\">\n" +
+            "    <module id=\"2\" name=\"common\">\n" +
             "        <protocol id=\"3000\" location=\"com.zfoo.test.CM_Float\"/>\n" +
             "    </module>\n" +
             "</protocols>";