mirror of
https://github.com/tiennm99/DocsGPT.git
synced 2026-10-05 00:13:01 +00:00
- .zed/settings.json: ruff + basedpyright for Python (no format on save, the tree is not ruff-format clean), ESLint fixes then Prettier for the frontend, scan exclusions for caches and build outputs, .jwt_secret_key as private - .zed/tasks.json: dev services, API, worker, frontend, pytest/vitest for the current file or test, linting, uv lock + requirements export - .zed/debug.json: debugpy targets matching .vscode/launch.json - .editorconfig: whitespace rules for every editor - [tool.pyright] in pyproject.toml: venv, import root and excludes shared by pyright, basedpyright and Pylance - .gitignore: track only the shared files under .zed/ - CONTRIBUTING: editor setup section; fix the stale ESLint config path
183 lines
8.3 KiB
Markdown
183 lines
8.3 KiB
Markdown
# Welcome to DocsGPT Contributing Guidelines
|
|
|
|
Thank you for choosing to contribute to DocsGPT! We are all very grateful!
|
|
|
|
# We accept different types of contributions
|
|
|
|
📣 **Discussions** - Engage in conversations, start new topics, or help answer questions.
|
|
|
|
🐞 **Issues** - This is where we keep track of tasks. It could be bugs, fixes or suggestions for new features.
|
|
|
|
🛠️ **Pull requests** - Suggest changes to our repository, either by working on existing issues or adding new features.
|
|
|
|
📚 **Wiki** - This is where our documentation resides.
|
|
|
|
|
|
## 🐞 Issues and Pull requests
|
|
|
|
- We value contributions in the form of discussions or suggestions. We recommend taking a look at existing issues and our [roadmap](https://github.com/orgs/arc53/projects/2).
|
|
|
|
|
|
- If you're interested in contributing code, here are some important things to know:
|
|
|
|
- We have a frontend built on React (Vite) and a backend in Python.
|
|
|
|
> **Required for every PR:** Please attach screenshots or a short screen
|
|
> recording that shows the working version of your changes. This makes the
|
|
> requirement visible to reviewers and helps them quickly verify what you are
|
|
> submitting.
|
|
|
|
|
|
Before creating issues, please check out how the latest version of our app looks and works by launching it via [Quickstart](https://github.com/arc53/DocsGPT#quickstart) the version on our live demo is slightly modified with login. Your issues should relate to the version you can launch via [Quickstart](https://github.com/arc53/DocsGPT#quickstart).
|
|
|
|
### 👨💻 If you're interested in contributing code, here are some important things to know:
|
|
|
|
For instructions on setting up a development environment, please refer to our [Development Deployment Guide](https://docs.docsgpt.cloud/Deploying/Development-Environment).
|
|
|
|
Tech Stack Overview:
|
|
|
|
- 🌐 Frontend: Built with React (Vite) ⚛️,
|
|
|
|
- 🖥 Backend: Developed in Python 🐍
|
|
|
|
### 🌐 Frontend Contributions (⚛️ React, Vite)
|
|
|
|
* The updated Figma design can be found [here](https://www.figma.com/file/OXLtrl1EAy885to6S69554/DocsGPT?node-id=0%3A1&t=hjWVuxRg9yi5YkJ9-1). Please try to follow the guidelines.
|
|
* **Coding Style:** We follow a strict coding style enforced by ESLint and Prettier. Please ensure your code adheres to the configuration provided in our repository's `frontend/eslint.config.js` and `frontend/prettier.config.cjs` files. We recommend configuring your editor with ESLint and Prettier to help with this.
|
|
* **Component Structure:** Strive for small, reusable components. Favor functional components and hooks over class components where possible.
|
|
* **State Management** If you need to add stores, please use Redux.
|
|
|
|
### 🖥 Backend Contributions (🐍 Python)
|
|
|
|
- Review our issues and contribute to [`/docsgpt`](https://github.com/arc53/DocsGPT/tree/main/docsgpt)
|
|
- All new code should be covered with unit tests ([pytest](https://github.com/pytest-dev/pytest)). Please find tests under [`/tests`](https://github.com/arc53/DocsGPT/tree/main/tests) folder.
|
|
- Before submitting your Pull Request, ensure it can be queried after ingesting some test data.
|
|
- **Coding Style:** We adhere to the [PEP 8](https://www.python.org/dev/peps/pep-0008/) style guide for Python code. We use `ruff` as our linter and code formatter. Please ensure your code is formatted correctly and passes `ruff` checks before submitting.
|
|
- **Type Hinting:** Please use type hints for all function arguments and return values. This improves code readability and helps catch errors early. Example:
|
|
|
|
```python
|
|
def my_function(name: str, count: int) -> list[str]:
|
|
...
|
|
```
|
|
- **Docstrings:** All functions and classes should have docstrings explaining their purpose, parameters, and return values. We prefer the [Google style docstrings](https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html). Example:
|
|
|
|
```python
|
|
def my_function(name: str, count: int) -> list[str]:
|
|
"""Does something with a name and a count.
|
|
|
|
Args:
|
|
name: The name to use.
|
|
count: The number of times to do it.
|
|
|
|
Returns:
|
|
A list of strings.
|
|
"""
|
|
...
|
|
```
|
|
|
|
### Editor setup
|
|
|
|
Some configuration is shared by every editor, so you rarely need to set anything up by hand:
|
|
|
|
- [`.editorconfig`](https://editorconfig.org) holds the whitespace rules (4 spaces for Python, 2 for TypeScript/JSON/YAML, LF line endings, final newline). Most editors read it natively or through a plugin.
|
|
- `[tool.pyright]` in `pyproject.toml` points Pyright, basedpyright and Pylance at the `.venv` created by `uv sync` and at the repository root for imports.
|
|
- `.ruff.toml`, `frontend/eslint.config.js` and `frontend/prettier.config.cjs` are picked up by the matching editor integrations.
|
|
|
|
Editor-specific configuration that is tracked:
|
|
|
|
- **VS Code:** `.vscode/launch.json` has debug targets for the API, the Celery worker and the frontend.
|
|
- **Zed:** open the repository root (not `frontend/`). `.zed/settings.json` configures the language servers and formatters, `.zed/tasks.json` adds tasks (`task: spawn`) for the dev services, the API, the worker, the frontend, tests and linting, and `.zed/debug.json` adds debug targets (`debugger: start`). Python files are not formatted on save because most of the tree is not `ruff format` clean; frontend files are, with ESLint fixes followed by Prettier, as in the pre-commit hook. Project settings cannot install extensions, so if you want the matching syntax support add this to your own Zed settings:
|
|
|
|
```json
|
|
{
|
|
"auto_install_extensions": {
|
|
"dockerfile": true,
|
|
"docker-compose": true,
|
|
"toml": true,
|
|
"mdx": true
|
|
}
|
|
}
|
|
```
|
|
|
|
Personal preferences belong in your user settings; `.vscode/settings.json` and any other file under `.zed/` are ignored by git.
|
|
|
|
### Testing
|
|
|
|
To run unit tests from the root of the repository, execute:
|
|
```
|
|
python -m pytest
|
|
```
|
|
|
|
## Workflow 📈
|
|
|
|
Here's a step-by-step guide on how to contribute to DocsGPT:
|
|
|
|
1. **Fork the Repository:**
|
|
- Click the "Fork" button at the top-right of this repository to create your fork.
|
|
|
|
2. **Clone the Forked Repository:**
|
|
- Clone the repository using:
|
|
``` shell
|
|
git clone https://github.com/<your-github-username>/DocsGPT.git
|
|
```
|
|
|
|
3. **Keep your Fork in Sync:**
|
|
- Before you make any changes, make sure that your fork is in sync to avoid merge conflicts using:
|
|
```shell
|
|
git remote add upstream https://github.com/arc53/DocsGPT.git
|
|
git pull upstream main
|
|
```
|
|
|
|
4. **Create and Switch to a New Branch:**
|
|
- Create a new branch for your contribution using:
|
|
```shell
|
|
git checkout -b your-branch-name
|
|
```
|
|
|
|
5. **Make Changes:**
|
|
- Make the required changes in your branch.
|
|
|
|
6. **Add Changes to the Staging Area:**
|
|
- Add your changes to the staging area using:
|
|
```shell
|
|
git add .
|
|
```
|
|
|
|
7. **Commit Your Changes:**
|
|
- Commit your changes with a descriptive commit message using:
|
|
```shell
|
|
git commit -m "Your descriptive commit message"
|
|
```
|
|
|
|
8. **Push Your Changes to the Remote Repository:**
|
|
- Push your branch with changes to your fork on GitHub using:
|
|
```shell
|
|
git push origin your-branch-name
|
|
```
|
|
|
|
9. **Submit a Pull Request (PR):**
|
|
- Create a Pull Request from your branch to the main repository. Make sure to include a detailed description of your changes, reference any related issues, and attach screenshots or a screen recording showing the working version.
|
|
|
|
10. **Collaborate:**
|
|
- Be responsive to comments and feedback on your PR.
|
|
- Make necessary updates as suggested.
|
|
- Once your PR is approved, it will be merged into the main repository.
|
|
|
|
11. **Testing:**
|
|
- Before submitting a Pull Request, ensure your code passes all unit tests.
|
|
- To run unit tests from the root of the repository, execute:
|
|
```shell
|
|
python -m pytest
|
|
```
|
|
|
|
*Note: You should run the unit test only after making the changes to the backend code.*
|
|
|
|
12. **Questions and Collaboration:**
|
|
- Feel free to join our Discord. We're very friendly and welcoming to new contributors, so don't hesitate to reach out.
|
|
|
|
Thank you for considering contributing to DocsGPT! 🙏
|
|
|
|
## Questions/collaboration
|
|
Feel free to join our [Discord](https://discord.gg/vN7YFfdMpj). We're very friendly and welcoming to new contributors, so don't hesitate to reach out.
|
|
# Thank you so much for considering to contributing DocsGPT!🙏
|