tiennm99/ccs
1
0
Fork 0
mirror of https://github.com/tiennm99/ccs.git synced 2026-07-19 16:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1133 from seilk/fix/tool-result-image-placeholders

Browse Source 
fix(proxy): stringify tool_result images for OpenAI upstreams
This commit is contained in:
Kai (Tam Nhu) Tran
2026-04-29 14:48:57 -04:00
committed by GitHub
parent 7569c6ce2d 2c0f9c41ff
commit a35824f28d
2 changed files with 51 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/proxy/transformers/request-transformer.ts
+12 -1
View File
@@ -219,7 +219,18 @@ function convertToolResultContent(content: unknown, isError: boolean, label: str
}
if (parsed.type === 'image') {
throw new Error(`${label}[${index}].type "image" is not supported in tool_result content`);
const source =
typeof parsed.source === 'object' && parsed.source !== null
? (parsed.source as Record<string, unknown>)
: undefined;
const description =
source?.type === 'url'
? 'url image payload'
: source?.type === 'base64' && typeof source.media_type === 'string'
? `${source.media_type} base64 payload`
: 'unsupported image payload';
parts.push(`[tool_result image omitted: ${description}]`);
continue;
}
if (typeof parsed.text === 'string') {
tests/unit/proxy/transformers/request-transformer-regressions.test.ts
+39 -21
View File
@@ -189,27 +189,45 @@ describe('ProxyRequestTransformer regressions', () => {
).toThrow('must start with tool_result blocks for pending tool_use ids');
});
it('rejects tool_result content that cannot be represented as OpenAI tool text', () => {
expect(() =>
new ProxyRequestTransformer().transform({
messages: [
{
role: 'assistant',
content: [{ type: 'tool_use', id: 'toolu_1', name: 'vision', input: { detail: 'high' } }],
},
{
role: 'user',
content: [
{
type: 'tool_result',
tool_use_id: 'toolu_1',
content: [{ type: 'image', source: { type: 'url', url: 'https://example.com/error.png' } }],
},
],
},
],
})
).toThrow('type "image" is not supported in tool_result content');
it('converts tool_result image blocks to text placeholders for OpenAI-compatible tool messages', () => {
const result = new ProxyRequestTransformer().transform({
messages: [
{
role: 'assistant',
content: [{ type: 'tool_use', id: 'toolu_1', name: 'vision', input: { detail: 'high' } }],
},
{
role: 'user',
content: [
{
type: 'tool_result',
tool_use_id: 'toolu_1',
content: [
{ type: 'text', text: 'screenshot captured' },
{
type: 'image',
source: { type: 'url', url: 'https://storage.example.com/error.png?X-Amz-Signature=secret' },
},
{
type: 'image',
source: { type: 'base64', media_type: 'image/png', data: 'ZmFrZQ==' },
},
],
},
],
},
],
});
expect(result.messages[1]).toEqual({
role: 'tool',
tool_call_id: 'toolu_1',
content:
'screenshot captured\n[tool_result image omitted: url image payload]\n[tool_result image omitted: image/png base64 payload]',
});
expect(result.messages[1]?.content).not.toContain('https://storage.example.com');
expect(result.messages[1]?.content).not.toContain('X-Amz-Signature');
expect(result.messages[1]?.content).not.toContain('secret');
});
it('rejects unsupported assistant blocks instead of silently dropping them', () => {