fix: improve error caching behavoir (#2211)

This commit ensures that the GraphQL Pat error is not cached in any
browser. See
https://github.com/anuraghazra/github-readme-stats/issues/1471#issuecomment-1282630614.
This commit is contained in:
Rick Staa
2022-10-18 18:07:38 +02:00
committed by GitHub
parent dcc4ccd18c
commit 98f9045f98
5 changed files with 5 additions and 5 deletions
+1 -1
View File
@@ -89,7 +89,7 @@ export default async (req, res) => {
}),
);
} catch (err) {
res.setHeader("Cache-Control", `no-store`); // Don't cache error responses.
res.setHeader("Cache-Control", `no-cache, no-store, must-revalidate`); // Don't cache error responses.
return res.send(renderError(err.message, err.secondaryMessage));
}
};
+1 -1
View File
@@ -75,7 +75,7 @@ export default async (req, res) => {
}),
);
} catch (err) {
res.setHeader("Cache-Control", `no-store`); // Don't cache error responses.
res.setHeader("Cache-Control", `no-cache, no-store, must-revalidate`); // Don't cache error responses.
return res.send(renderError(err.message, err.secondaryMessage));
}
};
+1 -1
View File
@@ -76,7 +76,7 @@ export default async (req, res) => {
}),
);
} catch (err) {
res.setHeader("Cache-Control", `no-store`); // Don't cache error responses.
res.setHeader("Cache-Control", `no-cache, no-store, must-revalidate`); // Don't cache error responses.
return res.send(renderError(err.message, err.secondaryMessage));
}
};
+1 -1
View File
@@ -78,7 +78,7 @@ export default async (req, res) => {
}),
);
} catch (err) {
res.setHeader("Cache-Control", `no-store`); // Don't cache error responses.
res.setHeader("Cache-Control", `no-cache, no-store, must-revalidate`); // Don't cache error responses.
return res.send(renderError(err.message, err.secondaryMessage));
}
};
+1 -1
View File
@@ -180,7 +180,7 @@ describe("Test /api/", () => {
expect(res.setHeader.mock.calls).toEqual([
["Content-Type", "image/svg+xml"],
["Cache-Control", `no-store`],
["Cache-Control", `no-cache, no-store, must-revalidate`],
]);
});