tiennm99/goclaw
1
0
Fork 0
mirror of https://github.com/tiennm99/goclaw.git synced 2026-09-10 04:19:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(lint): apply Go best practices across codebase

Browse Source 
- Use errors.Is() instead of direct sentinel comparison (13 instances)
- Convert if/else-if chains to switch/case for same-variable comparisons
- Remove redundant bitwise OR with zero
- Add post-implementation checklist to CLAUDE.md
This commit is contained in:
viettranx
2026-03-07 20:51:39 +07:00
parent df684e2582
commit b62d46e50e
14 changed files with 56 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CLAUDE.md
+16
View File
@@ -61,3 +61,19 @@ go test -v ./tests/integration/ # Integration tests
cd ui/web && pnpm install && pnpm dev # Web dashboard (dev)
```
## Post-Implementation Checklist
After implementing or modifying Go code, run these checks:
```bash
go build ./... # Compile check
go vet ./... # Static analysis
go test -race ./tests/integration/ # Integration tests with race detector
```
Go conventions to follow:
- Use `errors.Is(err, sentinel)` instead of `err == sentinel`
- Use `switch/case` instead of `if/else if` chains on the same variable
- Use `append(dst, src...)` instead of loop-based append
- Always handle errors; don't ignore return values
cmd/gateway_providers.go
+6 -5
View File
@@ -170,21 +170,22 @@ func registerProvidersFromDB(registry *providers.Registry, provStore store.Provi
if p.APIKey == "" {
continue
}
if p.ProviderType == store.ProviderChatGPTOAuth {
switch p.ProviderType {
case store.ProviderChatGPTOAuth:
ts := oauth.NewDBTokenSource(provStore, secretStore, p.Name)
registry.Register(providers.NewCodexProvider(p.Name, ts, p.APIBase, ""))
} else if p.ProviderType == store.ProviderAnthropicNative {
case store.ProviderAnthropicNative:
registry.Register(providers.NewAnthropicProvider(p.APIKey,
providers.WithAnthropicBaseURL(p.APIBase)))
} else if p.ProviderType == store.ProviderDashScope {
case store.ProviderDashScope:
registry.Register(providers.NewDashScopeProvider(p.APIKey, p.APIBase, ""))
} else if p.ProviderType == store.ProviderBailian {
case store.ProviderBailian:
base := p.APIBase
if base == "" {
base = "https://coding-intl.dashscope.aliyuncs.com/v1"
}
registry.Register(providers.NewOpenAIProvider(p.Name, p.APIKey, base, "qwen3.5-plus"))
} else {
default:
prov := providers.NewOpenAIProvider(p.Name, p.APIKey, p.APIBase, "")
if p.ProviderType == store.ProviderMiniMax {
prov.WithChatPath("/text/chatcompletion_v2")
cmd/gateway_tsnet.go
+2 -1
View File
@@ -4,6 +4,7 @@ package cmd
import (
"context"
"errors"
"log/slog"
"net"
"net/http"
@@ -59,7 +60,7 @@ func initTailscale(ctx context.Context, cfg *config.Config, mux http.Handler) fu
httpSrv := &http.Server{Handler: mux}
go func() {
if err := httpSrv.Serve(ln); err != nil && err != http.ErrServerClosed {
if err := httpSrv.Serve(ln); err != nil && !errors.Is(err, http.ErrServerClosed) {
slog.Warn("Tailscale HTTP server error", "error", err)
}
}()
cmd/migrate.go
+4 -3
View File
@@ -3,6 +3,7 @@ package cmd
import (
"context"
"database/sql"
"errors"
"fmt"
"log/slog"
"os"
@@ -93,7 +94,7 @@ func migrateUpCmd() *cobra.Command {
}
defer m.Close()
if err := m.Up(); err != nil && err != migrate.ErrNoChange {
if err := m.Up(); err != nil && !errors.Is(err, migrate.ErrNoChange) {
return fmt.Errorf("migrate up: %w", err)
}
@@ -139,7 +140,7 @@ func migrateDownCmd() *cobra.Command {
if steps <= 0 {
steps = 1
}
if err := m.Steps(-steps); err != nil && err != migrate.ErrNoChange {
if err := m.Steps(-steps); err != nil && !errors.Is(err, migrate.ErrNoChange) {
return fmt.Errorf("migrate down: %w", err)
}
@@ -226,7 +227,7 @@ func migrateGotoCmd() *cobra.Command {
}
defer m.Close()
if err := m.Migrate(uint(version)); err != nil && err != migrate.ErrNoChange {
if err := m.Migrate(uint(version)); err != nil && !errors.Is(err, migrate.ErrNoChange) {
return fmt.Errorf("migrate goto: %w", err)
}
slog.Info("migrated to version", "version", version)
cmd/upgrade.go
+2 -2
View File
@@ -168,7 +168,7 @@ func runUpgrade(dryRun bool) error {
}
defer m.Close()
if err := m.Up(); err != nil && err != migrate.ErrNoChange {
if err := m.Up(); err != nil && !errors.Is(err, migrate.ErrNoChange) {
fmt.Println("FAILED")
return fmt.Errorf("migrate up: %w", err)
}
@@ -240,7 +240,7 @@ func checkSchemaOrAutoUpgrade(dsn string) error {
}
defer m.Close()
if mErr := m.Up(); mErr != nil && mErr != migrate.ErrNoChange {
if mErr := m.Up(); mErr != nil && !errors.Is(mErr, migrate.ErrNoChange) {
return fmt.Errorf("auto-upgrade: migrate up: %w", mErr)
}
internal/channels/feishu/feishu.go
+2 -1
View File
@@ -6,6 +6,7 @@ package feishu
import (
"context"
"encoding/json"
"errors"
"fmt"
"log/slog"
"net/http"
@@ -278,7 +279,7 @@ func (c *Channel) startWebhook(ctx context.Context) error {
}
go func() {
if err := c.httpServer.ListenAndServe(); err != nil && err != http.ErrServerClosed {
if err := c.httpServer.ListenAndServe(); err != nil && !errors.Is(err, http.ErrServerClosed) {
slog.Error("feishu webhook server error", "error", err)
}
}()
internal/channels/feishu/larkws_proto.go
+3 -2
View File
@@ -3,6 +3,7 @@ package feishu
import (
"bytes"
"encoding/binary"
"errors"
"fmt"
"io"
)
@@ -83,7 +84,7 @@ func unmarshalFrame(data []byte) (*wsFrame, error) {
for r.Len() > 0 {
tag, err := binary.ReadUvarint(r)
if err != nil {
if err == io.EOF {
if errors.Is(err, io.EOF) {
break
}
return nil, fmt.Errorf("read tag: %w", err)
@@ -181,7 +182,7 @@ func unmarshalHeader(data []byte) (wsHeader, error) {
// --- Protobuf encoding helpers ---
func pbWriteVarintField(w *bytes.Buffer, fieldNum int, val uint64) {
tag := uint64(fieldNum<<3 | 0) // wire type 0 = varint
tag := uint64(fieldNum << 3) // wire type 0 = varint
pbWriteUvarint(w, tag)
pbWriteUvarint(w, val)
}
internal/gateway/server.go
+2 -1
View File
@@ -2,6 +2,7 @@ package gateway
import (
"context"
"errors"
"fmt"
"log/slog"
"net"
@@ -247,7 +248,7 @@ func (s *Server) Start(ctx context.Context) error {
s.httpServer.Shutdown(shutdownCtx)
}()
if err := s.httpServer.ListenAndServe(); err != http.ErrServerClosed {
if err := s.httpServer.ListenAndServe(); !errors.Is(err, http.ErrServerClosed) {
return fmt.Errorf("gateway server: %w", err)
}
return nil
internal/http/providers.go
+6 -5
View File
@@ -94,21 +94,22 @@ func (h *ProvidersHandler) registerInMemory(p *store.LLMProviderData) {
if p.APIKey == "" {
return
}
if p.ProviderType == store.ProviderChatGPTOAuth {
switch p.ProviderType {
case store.ProviderChatGPTOAuth:
ts := oauth.NewDBTokenSource(h.store, h.secretStore, p.Name)
h.providerReg.Register(providers.NewCodexProvider(p.Name, ts, p.APIBase, ""))
} else if p.ProviderType == store.ProviderAnthropicNative {
case store.ProviderAnthropicNative:
h.providerReg.Register(providers.NewAnthropicProvider(p.APIKey,
providers.WithAnthropicBaseURL(p.APIBase)))
} else if p.ProviderType == store.ProviderDashScope {
case store.ProviderDashScope:
h.providerReg.Register(providers.NewDashScopeProvider(p.APIKey, p.APIBase, ""))
} else if p.ProviderType == store.ProviderBailian {
case store.ProviderBailian:
base := p.APIBase
if base == "" {
base = "https://coding-intl.dashscope.aliyuncs.com/v1"
}
h.providerReg.Register(providers.NewOpenAIProvider(p.Name, p.APIKey, base, "qwen3.5-plus"))
} else {
default:
prov := providers.NewOpenAIProvider(p.Name, p.APIKey, p.APIBase, "")
if p.ProviderType == store.ProviderMiniMax {
prov.WithChatPath("/text/chatcompletion_v2")
internal/oauth/openai.go
+2 -1
View File
@@ -4,6 +4,7 @@ package oauth
import (
"context"
"crypto/rand"
"errors"
"crypto/sha256"
"encoding/base64"
"encoding/json"
@@ -182,7 +183,7 @@ func StartLoginOpenAI() (*PendingLogin, error) {
srv := &http.Server{Handler: mux}
go func() {
if err := srv.Serve(listener); err != nil && err != http.ErrServerClosed {
if err := srv.Serve(listener); err != nil && !errors.Is(err, http.ErrServerClosed) {
errCh <- fmt.Errorf("callback server: %w", err)
}
}()
internal/store/pg/agents_context.go
+2 -1
View File
@@ -3,6 +3,7 @@ package pg
import (
"context"
"database/sql"
"errors"
"path/filepath"
"time"
@@ -118,7 +119,7 @@ func (s *PGAgentStore) GetUserOverride(ctx context.Context, agentID uuid.UUID, u
agentID, userID,
).Scan(&d.AgentID, &d.UserID, &d.Provider, &d.Model)
if err != nil {
if err == sql.ErrNoRows {
if errors.Is(err, sql.ErrNoRows) {
return nil, nil // not found = no override
}
return nil, nil
internal/store/pg/teams.go
+3 -2
View File
@@ -4,6 +4,7 @@ import (
"context"
"database/sql"
"encoding/json"
"errors"
"time"
"github.com/google/uuid"
@@ -156,7 +157,7 @@ func (s *PGTeamStore) GetTeamForAgent(ctx context.Context, agentID uuid.UUID) (*
LIMIT 1`, agentID, store.TeamStatusActive)
d, err := scanTeamRow(row)
if err == sql.ErrNoRows {
if errors.Is(err, sql.ErrNoRows) {
return nil, nil
}
return d, err
@@ -220,7 +221,7 @@ func (s *PGTeamStore) GetHandoffRoute(ctx context.Context, channel, chatID strin
&d.ID, &d.Channel, &d.ChatID, &d.FromAgentKey, &d.ToAgentKey,
&d.Reason, &d.CreatedBy, &d.CreatedAt,
)
if err == sql.ErrNoRows {
if errors.Is(err, sql.ErrNoRows) {
return nil, nil
}
if err != nil {
internal/tools/create_image.go
+4 -3
View File
@@ -98,15 +98,16 @@ func (t *CreateImageTool) Execute(ctx context.Context, args map[string]interface
// - others (openai, etc.): /images/generations
var imageBytes []byte
var usage *providers.Usage
if providerName == "gemini" {
switch providerName {
case "gemini":
var genErr error
imageBytes, usage, genErr = t.callGeminiNativeImageGen(ctx, cp.APIKey(), cp.APIBase(), model, prompt)
err = genErr
} else if providerName == "openrouter" {
case "openrouter":
var genErr error
imageBytes, usage, genErr = t.callImageGenAPI(ctx, cp.APIKey(), cp.APIBase(), model, prompt, aspectRatio)
err = genErr
} else {
default:
var genErr error
imageBytes, usage, genErr = t.callStandardImageGenAPI(ctx, cp.APIKey(), cp.APIBase(), model, prompt)
err = genErr
internal/tools/shell.go
+2 -1
View File
@@ -3,6 +3,7 @@ package tools
import (
"bytes"
"context"
"errors"
"fmt"
"log/slog"
"os/exec"
@@ -297,7 +298,7 @@ func (t *ExecTool) executeOnHost(ctx context.Context, command, cwd string) *Resu
func (t *ExecTool) executeInSandbox(ctx context.Context, command, cwd, sandboxKey string) *Result {
sb, err := t.sandboxMgr.Get(ctx, sandboxKey, t.workingDir)
if err != nil {
if err == sandbox.ErrSandboxDisabled {
if errors.Is(err, sandbox.ErrSandboxDisabled) {
return t.executeOnHost(ctx, command, cwd)
}
// Docker unavailable (binary missing, daemon down) → fallback to host