tiennm99/godot
1
0
Fork 0
mirror of https://github.com/tiennm99/godot.git synced 2026-08-17 02:23:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #64025 from kleonc/filesystem-dock-rename-crash-fix

Browse Source 
`FileSystemDock` Fix crash when renaming a file in split mode
This commit is contained in:
Rémi Verschelde
2022-08-07 09:26:39 +02:00
committed by GitHub
parent 52c311fc34 25ce459fc5
commit f85a816965
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editor/filesystem_dock.cpp
+1 -2
View File
@@ -1531,14 +1531,13 @@ void FileSystemDock::_folder_removed(String p_folder) {
void FileSystemDock::_rename_operation_confirm() {
String new_name = rename_dialog_text->get_text().strip_edges();
String old_name = tree->get_selected()->get_text(0);
if (new_name.length() == 0) {
EditorNode::get_singleton()->show_warning(TTR("No name provided."));
return;
} else if (new_name.contains("/") || new_name.contains("\\") || new_name.contains(":")) {
EditorNode::get_singleton()->show_warning(TTR("Name contains invalid characters."));
return;
} else if (to_rename.is_file && old_name.get_extension() != new_name.get_extension()) {
} else if (to_rename.is_file && to_rename.path.get_extension() != new_name.get_extension()) {
if (!EditorFileSystem::get_singleton()->get_valid_extensions().find(new_name.get_extension())) {
EditorNode::get_singleton()->show_warning(TTR("This file extension is not recognized by the editor.\nIf you want to rename it anyway, use your operating system's file manager.\nAfter renaming to an unknown extension, the file won't be shown in the editor anymore."));
return;