mirror of
https://github.com/tiennm99/is-a-dev.git
synced 2026-05-30 22:24:33 +00:00
check deleted files ownership
This commit is contained in:
+25
-3
@@ -2,7 +2,7 @@ const t = require("ava");
|
||||
const fs = require("fs-extra");
|
||||
const path = require("path");
|
||||
|
||||
const requiredEnvVars = ["CHANGED_FILES", "PR_AUTHOR", "PR_AUTHOR_ID"];
|
||||
const requiredEnvVars = ["PR_AUTHOR", "PR_AUTHOR_ID"];
|
||||
const trustedUsers = require("../util/trusted.json").map((u) => u.id);
|
||||
|
||||
function getDomainData(subdomain) {
|
||||
@@ -17,13 +17,18 @@ function getDomainData(subdomain) {
|
||||
t("Users can only update their own subdomains", (t) => {
|
||||
if (requiredEnvVars.every((v) => process.env[v])) {
|
||||
const changedFiles = JSON.parse(process.env.CHANGED_FILES);
|
||||
const deletedFiles = JSON.parse(process.env.DELETED_FILES);
|
||||
const prAuthor = process.env.PR_AUTHOR.toLowerCase();
|
||||
const prAuthorId = process.env.PR_AUTHOR_ID;
|
||||
|
||||
const changedJSONFiles = changedFiles
|
||||
.filter((file) => file.startsWith("domains/"))
|
||||
.map((file) => path.basename(file));
|
||||
const deletedJSONFiles = deletedFiles
|
||||
.filter((file) => file.name.startsWith("domains/"))
|
||||
.map((file) => path.basename(file.name));
|
||||
|
||||
if (!changedJSONFiles || trustedUsers.includes(prAuthorId)) return t.pass();
|
||||
if ((!changedJSONFiles && !deletedFiles) || trustedUsers.includes(prAuthorId)) return t.pass();
|
||||
if (process.env.PR_LABELS && process.env.PR_LABELS.includes("bypass-owner-check")) return t.pass();
|
||||
|
||||
changedJSONFiles.forEach((file) => {
|
||||
@@ -32,7 +37,24 @@ t("Users can only update their own subdomains", (t) => {
|
||||
|
||||
t.true(
|
||||
data.owner.username.toLowerCase() === prAuthor,
|
||||
`${subdomain}: ${prAuthor} does not own ${subdomain}.is-a.dev`
|
||||
`${subdomain}: ${prAuthor} is not authorized to update ${subdomain}.is-a.dev`
|
||||
);
|
||||
});
|
||||
|
||||
deletedJSONFiles.forEach((file) => {
|
||||
const subdomain = file.replace(/\.json$/, "");
|
||||
const data = JSON.parse(
|
||||
deletedFiles
|
||||
.find((f) => f.name === `domains/${file}`)
|
||||
.data.split("\n")
|
||||
.filter((line) => line.startsWith("-") && !line.startsWith("---"))
|
||||
.map((line) => line.substring(1))
|
||||
.join("\n")
|
||||
);
|
||||
|
||||
t.true(
|
||||
data.owner.username.toLowerCase() === prAuthor,
|
||||
`${file}: ${prAuthor} is not authorized to delete ${subdomain}.is-a.dev`
|
||||
);
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user