tiennm99/litellm
1
0
Fork 0
mirror of https://github.com/tiennm99/litellm.git synced 2026-08-08 18:21:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: guard against null assigned_*_ids in update_access_group delta computation

Browse Source 
set(None) raises TypeError when a client sends null for assigned_team_ids or
assigned_key_ids. Add `or []` to handle null safely, consistent with create.
Add test covering this case.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
yuneng-jiang
2026-02-26 20:48:04 -08:00
co-authored by Claude Sonnet 4.6
parent 57c5efc785
commit 2144e79bad
2 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
litellm/proxy/management_endpoints/access_group_endpoints.py
+2 -2
View File
@@ -416,8 +416,8 @@ async def update_access_group(
old_team_ids: Set[str] = set(existing.assigned_team_ids or [])
old_key_ids: Set[str] = set(existing.assigned_key_ids or [])
new_team_ids: Set[str] = set(update_fields["assigned_team_ids"]) if "assigned_team_ids" in update_fields else old_team_ids
new_key_ids: Set[str] = set(update_fields["assigned_key_ids"]) if "assigned_key_ids" in update_fields else old_key_ids
new_team_ids: Set[str] = set(update_fields["assigned_team_ids"] or []) if "assigned_team_ids" in update_fields else old_team_ids
new_key_ids: Set[str] = set(update_fields["assigned_key_ids"] or []) if "assigned_key_ids" in update_fields else old_key_ids
teams_to_add = list(new_team_ids - old_team_ids)
teams_to_remove = list(old_team_ids - new_team_ids)
tests/test_litellm/proxy/management_endpoints/test_access_group_endpoints.py
+19
View File
@@ -1166,3 +1166,22 @@ def test_delete_access_group_handles_out_of_sync_assigned_keys(client_and_mocks)
mock_key_table.find_unique.assert_awaited_once_with(where={"token": "token-out-of-sync"})
mock_key_table.update.assert_not_awaited()
def test_update_access_group_null_assigned_ids_treated_as_empty(client_and_mocks):
"""Update with explicit null for assigned_*_ids clears the list without TypeError."""
client, _, mock_table, *_ = client_and_mocks
existing = _make_access_group_record(
access_group_id="ag-update",
assigned_team_ids=["team-1"],
assigned_key_ids=["key-1"],
)
mock_table.find_unique = AsyncMock(return_value=existing)
# Sending null for assigned_team_ids and assigned_key_ids
resp = client.put(
"/v1/access_group/ag-update",
json={"assigned_team_ids": None, "assigned_key_ids": None},
)
assert resp.status_code == 200