tiennm99/litellm
1
0
Fork 0
mirror of https://github.com/tiennm99/litellm.git synced 2026-08-05 10:24:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

addressing feedback around tests

Browse Source
This commit is contained in:
yuneng-jiang
2026-02-09 12:07:53 -08:00
parent fb4daad8d4
commit ff5a3acc1c
2 changed files with 71 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/litellm-dashboard/src/app/(dashboard)/hooks/mcpServers/useMCPAccessGroups.test.ts
+34 -4
View File
@@ -31,6 +31,7 @@ const wrapper = ({ children }: { children: React.ReactNode }) => {
return React.createElement(QueryClientProvider, { client: queryClient }, children);
};
const mockAccessToken = "test-token-456";
const mockAccessGroups = ["group-1", "group-2", "group-3"];
describe("useMCPAccessGroups", () => {
@@ -38,10 +39,22 @@ describe("useMCPAccessGroups", () => {
vi.clearAllMocks();
const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized");
vi.mocked(useAuthorizedModule.default).mockReturnValue({
accessToken: "test-token-456",
accessToken: mockAccessToken,
} as any);
});
it("should return hook result without errors", () => {
vi.mocked(networking.fetchMCPAccessGroups).mockResolvedValue([]);
const { result } = renderHook(() => useMCPAccessGroups(), { wrapper });
expect(result.current).toBeDefined();
expect(result.current).toHaveProperty("data");
expect(result.current).toHaveProperty("isSuccess");
expect(result.current).toHaveProperty("isError");
expect(result.current).toHaveProperty("status");
});
it("should return MCP access groups when access token is present", async () => {
vi.mocked(networking.fetchMCPAccessGroups).mockResolvedValue(mockAccessGroups);
@@ -51,11 +64,11 @@ describe("useMCPAccessGroups", () => {
expect(result.current.isSuccess).toBe(true);
});
expect(networking.fetchMCPAccessGroups).toHaveBeenCalledWith("test-token-456");
expect(networking.fetchMCPAccessGroups).toHaveBeenCalledWith(mockAccessToken);
expect(result.current.data).toEqual(mockAccessGroups);
});
it("should not fetch when access token is not available", async () => {
it("should not fetch when access token is null", async () => {
const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized");
vi.mocked(useAuthorizedModule.default).mockReturnValue({
accessToken: null,
@@ -63,7 +76,23 @@ describe("useMCPAccessGroups", () => {
const { result } = renderHook(() => useMCPAccessGroups(), { wrapper });
expect(result.current.status).toBe("pending");
expect(result.current.isFetching).toBe(false);
expect(result.current.isLoading).toBe(false);
expect(result.current.data).toBeUndefined();
expect(networking.fetchMCPAccessGroups).not.toHaveBeenCalled();
});
it("should not fetch when access token is empty string", async () => {
const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized");
vi.mocked(useAuthorizedModule.default).mockReturnValue({
accessToken: "",
} as any);
const { result } = renderHook(() => useMCPAccessGroups(), { wrapper });
expect(result.current.isFetching).toBe(false);
expect(result.current.isLoading).toBe(false);
expect(result.current.data).toBeUndefined();
expect(networking.fetchMCPAccessGroups).not.toHaveBeenCalled();
});
@@ -78,6 +107,7 @@ describe("useMCPAccessGroups", () => {
});
expect(result.current.error).toEqual(mockError);
expect(result.current.data).toBeUndefined();
});
it("should return empty array when API returns no groups", async () => {
ui/litellm-dashboard/src/app/(dashboard)/hooks/mcpServers/useMCPServers.test.ts
+37 -7
View File
@@ -10,7 +10,7 @@ vi.mock("@/components/networking", () => ({
fetchMCPServers: vi.fn(),
}));
vi.mock("../useAuthorized", () => ({
vi.mock("@/app/(dashboard)/hooks/useAuthorized", () => ({
default: vi.fn(() => ({
accessToken: "test-token-123",
})),
@@ -31,6 +31,7 @@ const wrapper = ({ children }: { children: React.ReactNode }) => {
return React.createElement(QueryClientProvider, { client: queryClient }, children);
};
const mockAccessToken = "test-token-123";
const mockServers = [
{
server_id: "server-1",
@@ -46,12 +47,24 @@ const mockServers = [
describe("useMCPServers", () => {
beforeEach(async () => {
vi.clearAllMocks();
const useAuthorizedModule = await import("../useAuthorized");
const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized");
vi.mocked(useAuthorizedModule.default).mockReturnValue({
accessToken: "test-token-123",
accessToken: mockAccessToken,
} as any);
});
it("should return hook result without errors", () => {
vi.mocked(networking.fetchMCPServers).mockResolvedValue([]);
const { result } = renderHook(() => useMCPServers(), { wrapper });
expect(result.current).toBeDefined();
expect(result.current).toHaveProperty("data");
expect(result.current).toHaveProperty("isSuccess");
expect(result.current).toHaveProperty("isError");
expect(result.current).toHaveProperty("status");
});
it("should return MCP servers when access token is present", async () => {
vi.mocked(networking.fetchMCPServers).mockResolvedValue(mockServers);
@@ -61,19 +74,35 @@ describe("useMCPServers", () => {
expect(result.current.isSuccess).toBe(true);
});
expect(networking.fetchMCPServers).toHaveBeenCalledWith("test-token-123");
expect(networking.fetchMCPServers).toHaveBeenCalledWith(mockAccessToken);
expect(result.current.data).toEqual(mockServers);
});
it("should not fetch when access token is not available", async () => {
const useAuthorizedModule = await import("../useAuthorized");
it("should not fetch when access token is null", async () => {
const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized");
vi.mocked(useAuthorizedModule.default).mockReturnValue({
accessToken: null,
} as any);
const { result } = renderHook(() => useMCPServers(), { wrapper });
expect(result.current.status).toBe("pending");
expect(result.current.isFetching).toBe(false);
expect(result.current.isLoading).toBe(false);
expect(result.current.data).toBeUndefined();
expect(networking.fetchMCPServers).not.toHaveBeenCalled();
});
it("should not fetch when access token is empty string", async () => {
const useAuthorizedModule = await import("@/app/(dashboard)/hooks/useAuthorized");
vi.mocked(useAuthorizedModule.default).mockReturnValue({
accessToken: "",
} as any);
const { result } = renderHook(() => useMCPServers(), { wrapper });
expect(result.current.isFetching).toBe(false);
expect(result.current.isLoading).toBe(false);
expect(result.current.data).toBeUndefined();
expect(networking.fetchMCPServers).not.toHaveBeenCalled();
});
@@ -88,6 +117,7 @@ describe("useMCPServers", () => {
});
expect(result.current.error).toEqual(mockError);
expect(result.current.data).toBeUndefined();
});
it("should return empty array when API returns empty list", async () => {