tiennm99/zfoo
1
0
Fork 0
mirror of https://github.com/tiennm99/zfoo.git synced 2026-05-19 07:26:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf[net]: rule checks for attachment

Browse Source
This commit is contained in:
godotg
2023-07-21 21:55:44 +08:00
parent 179070b709
commit dacd6421de
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
net/src/main/java/com/zfoo/net/router/route/PacketBus.java
+3 -2
View File
@@ -94,8 +94,9 @@ public abstract class PacketBus {
var expectedMethodName = StringUtils.format("at{}", packetClazz.getSimpleName());
AssertionUtils.isTrue(methodName.equals(expectedMethodName), "[class:{}] [method:{}] [packet:{}] expects '{}' as method name!", bean.getClass().getName(), methodName, packetName, expectedMethodName);
// If the request class name ends with Request, then the attachment should be a Gateway Attachment
// If the request class name ends with Ask, then attachment cannot be a Gateway Attachment
// These rules are not necessary, but can reduce us from making low-level mistakes
// If the request class name ends with Request which is for outer net client, then the attachment can not be a SignalAttachment
// If the request class name ends with Ask which is for intranet client, then attachment can not be a GatewayAttachment
if (attachmentClazz != null) {
if (packetName.endsWith(PacketService.NET_REQUEST_SUFFIX)) {
AssertionUtils.isTrue(!attachmentClazz.equals(SignalAttachment.class), "[class:{}] [method:{}] [packet:{}] must use [attachment:{}]!"