mirror of
https://github.com/tiennm99/is-a-dev.git
synced 2026-05-27 02:00:03 +00:00
Merge branch 'main' into main
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
# Reviewing pull requests
|
||||
There are a few things you'll need to look out for when reviewing pull requests for domain registrations. This list is not exhaustive and will be updated.
|
||||
|
||||
---
|
||||
|
||||
### CI errors
|
||||
A lot of minor issues will be caught in the CI checks
|
||||
@@ -9,24 +10,63 @@ A lot of minor issues will be caught in the CI checks
|
||||
|
||||
If the CI is failing, tag the user and comment on the pr.
|
||||
|
||||
---
|
||||
|
||||
### Contents of the website
|
||||
We need to make sure that the contents being hosted via the record being registered is used for malicious purposes.
|
||||
To do this, we must try our best to verify the contents of website and if required ask some questions regarding the contents in the PR.
|
||||
|
||||
---
|
||||
|
||||
### Invalid email/social link
|
||||
A way to contact the user is important in case we need to inform the users of some changes to the project.
|
||||
Confirm if the email looks valid or the social user name/link works.
|
||||
The user should have either an email or a valid social link.
|
||||
|
||||
❌ `"owner": { "username": "gh-username" }` is invalid as it doesn't contain an email or any social links
|
||||
|
||||
❌ `"email": "28372878+user-name@users.noreply.github.com"` is invalid as the email cannot be used
|
||||
|
||||
✅ `"owner": { "username": "phenax", "twitter": "twitter-username" }` is valid as it contains a social link
|
||||
|
||||
✅ `"owner": { "username": "phenax", "email": "email@gmail.com" }` is valid as it contains an email
|
||||
|
||||
---
|
||||
|
||||
### Invalid CNAME
|
||||
CNAME has to be a hostname. Something like 'example.com'.
|
||||
People tend to accidentally put a url there instead sometimes like `http://something.com` or `something.com/path`.
|
||||
Both of those are invalid.
|
||||
CNAME has to be a hostname. Something like `example.com`.
|
||||
|
||||
❌ `http://example.com` is invalid as it contains a protocol `https://`
|
||||
|
||||
❌ `example.com/some/path` is invalid as it contains the path name `/some/path`
|
||||
|
||||
✅ `example.com` is valid as it is the hostname of the website
|
||||
|
||||
---
|
||||
|
||||
### Invalid A
|
||||
A record has to be an array of ips
|
||||
A record has to be an array of ips.
|
||||
|
||||
❌ `"A": "211.211.211.211"` is invalid as it must be an array
|
||||
|
||||
❌ `"A": ["example.com"]` is invalid as it is not an ip address
|
||||
|
||||
✅ `"A": ["211.211.211.211", "211.211.211.212"]` is valid as it is an array of ips
|
||||
|
||||
---
|
||||
|
||||
### Invalid URL
|
||||
The URL must have a protocol (`http://` or `https://`) and must be something like `https://example.com` or `https://example.com/some/path`.
|
||||
|
||||
❌ `example.com` is invalid as it doesn't contain the protocol
|
||||
|
||||
✅ `https://example.com/some/path` is valid as it contains a protocol
|
||||
|
||||
---
|
||||
|
||||
### Only one record type
|
||||
Earlier, is-a-dev used to allow for handling https redirections along with CNAME but the way we handle requests has changed since then.
|
||||
This is why a record file can only contain one record type. Either `CNAME` or `A` or `URL`.
|
||||
|
||||
❌ `"CNAME": "example.com", "URL": "https://something.com"` is invalid as it should only contain one type of record, either CNAME or URL.
|
||||
|
||||
|
||||
@@ -0,0 +1,12 @@
|
||||
{
|
||||
"description": "Official WEBSITE OF aVNOOR gAMERZ",
|
||||
"repo": "https://github.com/Avnoor-Gamerz/avnoor-gamerz.github.io",
|
||||
"owner": {
|
||||
"username": "avnoor-gamerz",
|
||||
"email": "avnoorchahal001@gmail.com",
|
||||
"twitter": "avnoor-gamerz"
|
||||
},
|
||||
"record": {
|
||||
"CNAME": "avnoor-gamerz.github.io"
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,11 @@
|
||||
{
|
||||
"description": "Bedant Hota's Portfolio",
|
||||
"repo": "https://github.com/bedantH/bedantH.github.io",
|
||||
"owner": {
|
||||
"username": "bedantH",
|
||||
"email": "mohanesh.h2003@gmail.com"
|
||||
},
|
||||
"record": {
|
||||
"CNAME": "bedantH.github.io"
|
||||
}
|
||||
}
|
||||
+1
-1
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"URL": "https://calebden.io"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,11 @@
|
||||
{
|
||||
"description": "Redirection domain for my personal website",
|
||||
"repo": "https://github.com/cfanoulis/fanoulis.dev",
|
||||
"owner": {
|
||||
"username": "cfanoulis",
|
||||
"email": "domains@fanoulis.dev"
|
||||
},
|
||||
"record": {
|
||||
"URL": "https://fanoulis.dev"
|
||||
}
|
||||
}
|
||||
+1
-1
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"CNAME": "71bac7ca-1eac-46fe-9588-cd31d68b2e06.repl.co"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -9,4 +9,4 @@
|
||||
"record": {
|
||||
"CNAME": "deadshotofficial.github.io"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,11 @@
|
||||
{
|
||||
"description": "Hello there I am Didier Munezero",
|
||||
"repo": "https://github.com/didiermunezero",
|
||||
"owner": {
|
||||
"username": "didiermunezero",
|
||||
"email": "didiermunezer38@gmail.com"
|
||||
},
|
||||
"record": {
|
||||
"CNAME": "didiermunezero.github.io"
|
||||
}
|
||||
}
|
||||
+1
-1
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"URL": "https://dwii.my.id/"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -11,4 +11,4 @@
|
||||
"89.163.215.211"
|
||||
]
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"CNAME": "7xh.github.io"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -10,4 +10,4 @@
|
||||
"192.243.108.102"
|
||||
]
|
||||
}
|
||||
}
|
||||
}
|
||||
+1
-1
@@ -7,4 +7,4 @@
|
||||
"record": {
|
||||
"URL": "https://jasonaa.me/"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -1,11 +1,11 @@
|
||||
{
|
||||
"owner": {
|
||||
"username": "Koolwiza",
|
||||
"email": "koowliza@gmail.com"
|
||||
"email": "koolwiza@gmail.com"
|
||||
},
|
||||
"description": "Just a cool subdomain to have :)",
|
||||
"repo": "https://www.github.com/Koolwiza",
|
||||
"record": {
|
||||
"CNAME": "koolwiza.github.io"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"CNAME": "dazzling-williams-9e8070.netlify.app"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"URL": "https://mattglei.ch"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"CNAME": "lawliet.host"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -1,11 +1,11 @@
|
||||
{
|
||||
"description": "Omar Villafuerte",
|
||||
"repo": "https://github.com/ovillafuerte94/ovillafuerte94.github.io",
|
||||
"owner": {
|
||||
"username": "ovillafuerte94",
|
||||
"email": "ovillafuerte.94@gmail.com"
|
||||
},
|
||||
"record": {
|
||||
"CNAME": "ovillafuerte94.github.io"
|
||||
}
|
||||
"description": "Omar Villafuerte",
|
||||
"repo": "https://github.com/ovillafuerte94/ovillafuerte94.github.io",
|
||||
"owner": {
|
||||
"username": "ovillafuerte94",
|
||||
"email": "ovillafuerte.94@gmail.com"
|
||||
},
|
||||
"record": {
|
||||
"CNAME": "ovillafuerte94.github.io"
|
||||
}
|
||||
}
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"description": "Rahul Kiran Gaddam Profile",
|
||||
"repo":"https://github.com/rahgadda/rahgadda.github.io",
|
||||
"repo": "https://github.com/rahgadda/rahgadda.github.io",
|
||||
"owner": {
|
||||
"username": "rahgadda",
|
||||
"email": "gaddam.rahul@gmail.com"
|
||||
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"CNAME": "rahgadda.github.io"
|
||||
}
|
||||
}
|
||||
}
|
||||
+1
-1
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"URL": "https://rbansal.dev"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,10 @@
|
||||
{
|
||||
"owner": {
|
||||
"username": "CoolCoderSJ",
|
||||
"email": "CoolCoderSJ@gmail.com"
|
||||
},
|
||||
"description": "My CDN",
|
||||
"record": {
|
||||
"CNAME": "09d836a5-eaca-4299-bfec-44ca0dfc6d0d.repl.co"
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,11 @@
|
||||
{
|
||||
"description": "My main site :)",
|
||||
"repo": "https://replit.com/@RoBlockHead/tessais-adev",
|
||||
"owner": {
|
||||
"username": "RoBlockHead",
|
||||
"email": "tessa7551@gmail.com"
|
||||
},
|
||||
"record": {
|
||||
"CNAME": "06745170-24e7-4954-a619-2860f8b395c2.repl.co"
|
||||
}
|
||||
}
|
||||
@@ -1,4 +1,3 @@
|
||||
|
||||
{
|
||||
"description": "a website for my biotapi",
|
||||
"repo": "https://github.com/brawlie/todo",
|
||||
@@ -9,4 +8,4 @@
|
||||
"record": {
|
||||
"CNAME": "aa1b3bae-e49b-4efd-8c55-28719da5f58c.repl.co"
|
||||
}
|
||||
}
|
||||
}
|
||||
+10
-10
@@ -1,11 +1,11 @@
|
||||
{
|
||||
"repo": "https://github.com/makuzaverite/veritem.me",
|
||||
"owner": {
|
||||
"username": "makuzaverite",
|
||||
"email": "mugaboverite@gmail.com",
|
||||
"twitter": "makuza_mugabo_v"
|
||||
},
|
||||
"record": {
|
||||
"URL": "https://veritem.me"
|
||||
}
|
||||
}
|
||||
"repo": "https://github.com/makuzaverite/veritem.me",
|
||||
"owner": {
|
||||
"username": "makuzaverite",
|
||||
"email": "mugaboverite@gmail.com",
|
||||
"twitter": "makuza_mugabo_v"
|
||||
},
|
||||
"record": {
|
||||
"URL": "https://veritem.me"
|
||||
}
|
||||
}
|
||||
@@ -8,4 +8,4 @@
|
||||
"record": {
|
||||
"CNAME": "C1200.github.io"
|
||||
}
|
||||
}
|
||||
}
|
||||
+9
-9
@@ -1,10 +1,10 @@
|
||||
{
|
||||
"owner": {
|
||||
"username": "starptr",
|
||||
"email": "yuto@berkeley.edu"
|
||||
},
|
||||
"description": "Personal website",
|
||||
"record": {
|
||||
"URL": "https://yart.me"
|
||||
}
|
||||
}
|
||||
"owner": {
|
||||
"username": "starptr",
|
||||
"email": "yuto@berkeley.edu"
|
||||
},
|
||||
"description": "Personal website",
|
||||
"record": {
|
||||
"URL": "https://yart.me"
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user